Fix slash command skills bypassing cloud mode in old UI#9978
Draft
harryalbert wants to merge 1 commit intomasterfrom
Draft
Fix slash command skills bypassing cloud mode in old UI#9978harryalbert wants to merge 1 commit intomasterfrom
harryalbert wants to merge 1 commit intomasterfrom
Conversation
When a skill command (e.g. /some-skill) was typed in the old cloud mode UI (CloudModeInputV2 flag disabled), it was routed through execute_skill_command which enters the local agent view and sends the request locally, bypassing cloud mode entirely. The V2 UI already handled this correctly by returning false from maybe_handle_enter_for_slash_command when is_cloud_mode_input_v2_composing was true, letting the flow fall through to submit_ai_query which handles the cloud mode spawn_agent path. This fix broadens the guard from is_cloud_mode_input_v2_composing (which requires the V2 flag) to is_composing_cloud_mode_prompt (which only checks CloudMode flag + is_configuring_ambient_agent), covering both old and new cloud mode UIs. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix slash command skills bypassing cloud mode in the old cloud mode UI.
When a user typed a skill command (e.g.
/some-skill) in the old cloud mode UI (i.e., when theCloudModeInputV2feature flag is disabled), the command was routed throughexecute_skill_commandwhich enters the local agent view and sends the request locally—bypassing cloud mode entirely.The V2 UI already handled this correctly by returning
falsefrommaybe_handle_enter_for_slash_commandwhenis_cloud_mode_input_v2_composingwas true, letting the flow fall through tosubmit_ai_query→spawn_agent(the cloud mode path).The fix introduces
is_composing_cloud_mode_prompt, which checksCloudMode+is_configuring_ambient_agentwithout requiring the V2 flag. TheSkillCommandguards in bothmaybe_handle_enter_for_slash_commandandmaybe_handle_cmd_or_ctrl_shift_enter_for_slash_commandnow use this broader check, so skill commands in cloud mode setup are correctly submitted through the cloud agent spawn path regardless of which input UI is active.Linked Issue
Resolves REMOTE-1544
ready-to-specorready-to-implement.Testing
cargo check -p warp.cargo fmtpasses.Agent Mode
Conversation: https://staging.warp.dev/conversation/fada95ad-b0b0-4153-a682-747e44e28a0a
Run: https://oz.staging.warp.dev/runs/019dee48-2851-73a7-923f-1c4da590b296
This PR was generated with Oz.