feat: add per-tab theme override groundwork#9986
Draft
oz-for-oss[bot] wants to merge 1 commit intomasterfrom
Draft
feat: add per-tab theme override groundwork#9986oz-for-oss[bot] wants to merge 1 commit intomasterfrom
oz-for-oss[bot] wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Safia Abdalla <captainsafia@users.noreply.github.com>
Contributor
|
@gulsahsarsilmaz Looks like you've already seen this based on your reaction above but you're welcome to test this out locally/steer Oz on this PR to make changes as needed. |
Contributor
|
@captainsafia one issue here is that oz didn't implement the whole thing. We need a strategy that supports multiple PRs per issue I think. @oz-agent can you do the complete e2e implementation please |
Contributor
Author
|
I'm working on changes requested in this PR (responding to a PR conversation comment). Spec context was found and will be used to ground the change. You can view the conversation on Warp. Powered by Oz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #478
Summary
TabThemeState) with menu, launch-config, cwd, and window-default slots.theme:fields for tabs/windows and save logic for preserved overrides.Validation
cargo fmt --manifest-path /workspace/warp/app/Cargo.tomlcargo check --manifest-path /workspace/warp/Cargo.toml -p warp --libgit -C /workspace/warp --no-pager diff --checkFiltered unit-test builds were attempted, but the sandbox killed rustc with SIGKILL during lib-test compilation even with
CARGO_BUILD_JOBS=1.Notes
This is a scoped implementation update for the foundation of per-tab theme overrides. Remaining follow-up work includes renderer catalog/call-site migration, menu actions, and live directory/settings recomputation before the feature is fully user-visible.
Conversation: https://app.warp.dev/conversation/0f295f64-0c19-4e7f-a295-52d65342f327
Run: https://oz.warp.dev/runs/019def12-b234-75a7-95d7-9c3661c0c6de
Plans:
This PR was generated with Oz.