open local->cloud mode conversation in the same pane

[harryalbert]

Description

After posting a demo of local -> cloud handoff, I get some feedback (from peter, varoon, and ZL) that it would be better to just open the cloud mode session in the same pane as the local conversation. This makes sense to me, and we're still forking the conversation and opening up a new cloud mode pane so it's not like this is a destructive action (someone can just close the cloud mode view and re-open the local conversation view).

Implements REMOTE-1557

Screenshots / Videos

demo: https://www.loom.com/share/d2f67ee4e15245959210ef41d1dfe7c6

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

[harryalbert]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• open local->cloud mode conversation in the same pane #9988 👈 (View in Graphite)
• Use new cloud mode setup UI for local -> cloud handoff UI #9653
• implement local cloud handoff #9455
• Add 'continue' (in cloud) button to cloud agent conversation tombstone. #9315
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR changes local-to-cloud handoff so the forked cloud conversation is pushed onto the source pane's navigation stack instead of opening beside it.

Concerns

• start_cloud_mode now returns Option, but the updated normal cloud-mode entry paths ignore the must-use return value. Since this repository runs clippy with -D warnings, that warning will fail presubmit.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

⚠️ [IMPORTANT] Returning Option makes the call sites at lines 653 and 667 produce an unused_must_use warning; presubmit runs clippy with -D warnings, so either handle the failure or explicitly assign the intentionally ignored result to let _ = ....