Skip to content

spec: document wrapped rich CLI-agent link handling#9989

Open
oz-for-oss[bot] wants to merge 1 commit intomasterfrom
oz-agent/spec-issue-9385
Open

spec: document wrapped rich CLI-agent link handling#9989
oz-for-oss[bot] wants to merge 1 commit intomasterfrom
oz-agent/spec-issue-9385

Conversation

@oz-for-oss
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot commented May 3, 2026

Summary

  • Add a product spec for rich AI/CLI-agent output so Cmd+click opens the full URL when a long URL is split across adjacent rendered lines.
  • Add a tech spec comparing implementation options, recommending bounded rich-output URL reconstruction before detection, and calling out OSC 8 hyperlink support as a follow-up protocol improvement.
  • Document performance guardrails, false-positive risks in TUI layouts, markdown hyperlink precedence, terminal-grid non-regression, and validation coverage.

Validation

  • Spec-only change; validated by reviewing the generated diff.

Related issue: #9385

Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Zach Lloyd <zachlloyd@users.noreply.github.com>
@oz-for-oss
Copy link
Copy Markdown
Contributor Author

oz-for-oss Bot commented May 3, 2026

@oz-for-oss[bot]

I'm starting a first review of this spec-only pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor Author

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

The product and tech specs cover the GH9385 wrapped rich-output URL issue with clear goals, non-goals, implementation options, performance guardrails, and validation coverage.

Concerns

  • The proposed continuation heuristic does not explicitly exclude a following line that starts a new URL, which conflicts with the product success criterion that adjacent independent URLs remain separate.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread specs/GH9385/tech.md
When reconstructing adjacent formatted lines, treat a line boundary as a URL continuation only when all of these are true:

- The previous logical line currently ends inside a URL candidate or with URL-safe continuation characters.
- The next line begins with URL-safe continuation characters and does not begin with obvious prose, list markers, table delimiters, prompt prefixes, or indentation that suggests a separate layout cell.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This heuristic can join two adjacent independent URLs because https://... also begins with URL-safe characters and the concatenation may still be accepted by detect_urls; explicitly reject continuation lines that start a new URL scheme to satisfy the product success criterion.

Suggested change
- The next line begins with URL-safe continuation characters and does not begin with obvious prose, list markers, table delimiters, prompt prefixes, or indentation that suggests a separate layout cell.
- The next line begins with URL-safe continuation characters, does not itself start a new URL scheme, and does not begin with obvious prose, list markers, table delimiters, prompt prefixes, or indentation that suggests a separate layout cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant