spec: document wrapped rich CLI-agent link handling#9989
spec: document wrapped rich CLI-agent link handling#9989oz-for-oss[bot] wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Zach Lloyd <zachlloyd@users.noreply.github.com>
|
@oz-for-oss[bot] I'm starting a first review of this spec-only pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
The product and tech specs cover the GH9385 wrapped rich-output URL issue with clear goals, non-goals, implementation options, performance guardrails, and validation coverage.
Concerns
- The proposed continuation heuristic does not explicitly exclude a following line that starts a new URL, which conflicts with the product success criterion that adjacent independent URLs remain separate.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| When reconstructing adjacent formatted lines, treat a line boundary as a URL continuation only when all of these are true: | ||
|
|
||
| - The previous logical line currently ends inside a URL candidate or with URL-safe continuation characters. | ||
| - The next line begins with URL-safe continuation characters and does not begin with obvious prose, list markers, table delimiters, prompt prefixes, or indentation that suggests a separate layout cell. |
There was a problem hiding this comment.
https://... also begins with URL-safe characters and the concatenation may still be accepted by detect_urls; explicitly reject continuation lines that start a new URL scheme to satisfy the product success criterion.
| - The next line begins with URL-safe continuation characters and does not begin with obvious prose, list markers, table delimiters, prompt prefixes, or indentation that suggests a separate layout cell. | |
| - The next line begins with URL-safe continuation characters, does not itself start a new URL scheme, and does not begin with obvious prose, list markers, table delimiters, prompt prefixes, or indentation that suggests a separate layout cell. |
Summary
Validation
Related issue: #9385