Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Replace the changelog’s placeholder pull/0000 reference before merging.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds native Windows ARM64 support for downloading prebuilt wasm-opt binaries.
Changes:
- Maps Windows AArch64 to Binaryen’s
arm64-windowsarchive. - Enables the Windows ARM64 download test.
- Documents the fix in the changelog.
| File | Description |
|---|---|
tests/all/download.rs |
Tests wasm-opt downloads on Windows ARM64. |
src/install/mod.rs |
Adds the Windows ARM64 target mapping. |
CHANGELOG.md |
Records the new platform support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submittingDescription
Binaryen provides prebuilt
arm64-windowsrelease archives (e.g.binaryen-version_130-arm64-windows.tar.gz). Previously, runningwasm-packon Windows on ARM64 failed withUnrecognized target!when attempting to downloadwasm-opt.This PR adds the
(Os::Windows, Arch::AArch64, Tool::WasmOpt) => "arm64-windows"mapping toprebuilt_url_for, allowingwasm-packto automatically download and extract nativewasm-optbinaries on Windows ARM64 platforms.Relates to #1554 & #1604.
✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨