Add structured cache option with dir support and validation (docs, types, core, tests)#2275
Open
yuyutaotao wants to merge 1 commit intomainfrom
Open
Add structured cache option with dir support and validation (docs, types, core, tests)#2275yuyutaotao wants to merge 1 commit intomainfrom
cache option with dir support and validation (docs, types, core, tests)#2275yuyutaotao wants to merge 1 commit intomainfrom
Conversation
Deploying midscene with
|
| Latest commit: |
a861698
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23aba89c.midscene.pages.dev |
| Branch Preview URL: | https://codex-verify-cache-directory.midscene.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cacheoption (replacing ambiguouscacheIdusage) so callers can configure cache behavior and directory explicitly.<MIDSCENE_RUN_DIR>/cacheto isolate cache from logs/reports.Description
apps/site/docs/en/api.mdxandapps/site/docs/zh/api.mdx) to document the newcache?: false | { id: string; strategy?: 'read-only' | 'read-write' | 'write-only'; dir?: string }shape and markcacheIdas deprecated.packages/core/src/types.tsby addingdir?: stringtoCacheConfigand normalizing thecacheunion type.processCacheConfiginpackages/core/src/agent/agent.tsto validatecacheinputs (disallowcache: true, requireid, validate non-emptydir) and returndirectoryin the normalized config.TaskCacheby addingcacheDirectoryto its constructor options and using it to computecacheFilePathinpackages/core/src/agent/task-cache.ts.packages/web-integration/tests/unit-test/agent.test.tscovering custom cache directory behavior and the empty-dir validation error.Testing
packages/web-integrationincluding the new cache-dir cases and the tests passed.TaskCachebehavior and they passed.Codex Task