chore(infra): integrate skills-package-manager via prepare script by SoonIter · Pull Request #7565 · web-infra-dev/rsbuild

SoonIter · 2026-04-28T11:08:56Z

Summary

Add skills-package-manager to install agent skills during prepare and pin it to 0.11.0 in the pnpm catalog.
Keep installDir as .agents/skills and declare repo-owned skills with local:* so their sources stay in the existing .agents/skills/ directories.
Ignore generated remote skill install output and remove the old skills lock file.

Validation:

node --run format
node --run lint
node --run check-spell
NODE_OPTIONS=--max-old-space-size=6144 node --run test
NODE_OPTIONS=--max-old-space-size=6144 node --run e2e

Latest correction recheck:

node_modules/.bin/skills-package-manager install
node --run format
node --run lint
node --run check-spell

Code Review

This pull request integrates skills-package-manager into the project by adding it as a development dependency, initializing its configuration and lock files, and updating the .gitignore to exclude the skills installation directory. The prepare script in package.json was also updated to automatically run the skills installation. Feedback was provided regarding the potential for the prepare script to fail in production or restricted environments where dev dependencies are missing or the registry is unreachable, suggesting a more resilient implementation for the installation step.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Integrates skills-package-manager into the repo so agent skills are installed/synced automatically via the root prepare script during pnpm install.

Changes:

Add skills-package-manager@0.9.0 and run skills-package-manager install in prepare.
Introduce skills.json and skills-lock.yaml to define and lock skill sources.
Ignore generated .agents/skills/ output in .gitignore.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.

File	Description
skills.json	Adds the skills manifest (schema, install directory, and linked skills).
skills-lock.yaml	Adds a lockfile capturing resolved skill sources (link resolutions).
package.json	Installs skills during `prepare` and adds the tool as a dev dependency.
.gitignore	Prevents generated `.agents/skills/` content from being committed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 11 out of 14 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

## Summary - Add `local:` skill specifiers for existing user-owned skill directories. - Install `local:` skills in place without copying, replacing, patching, or pruning their source directories. - Link agent targets directly to the local source directory and maintain `.gitignore` unignore rules for repo-local skills. - Update tests, docs, and the bundled `skills-package-manager-cli` guidance. ## Related Links web-infra-dev/rsbuild#7565  ## Checklist  - [x] Tests updated (or not required). - [x] Documentation updated (or not required). Testing: - `pnpm build` - `pnpm test` - `pnpm build:website` - `pnpm check` (passes with existing warnings)

Copilot

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Copilot

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

coderabbitai · 2026-06-15T07:23:28Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 64134b2d-bfbd-4d93-be96-e88d1dd44146

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot AI review requested due to automatic review settings April 28, 2026 11:08

SoonIter marked this pull request as draft April 28, 2026 11:09

gemini-code-assist Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread package.json

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Comment thread skills-lock.yaml Outdated

Comment thread skills.json Outdated

SoonIter changed the title ~~chore: integrate skills-package-manager via prepare script~~ chore(infra): integrate skills-package-manager via prepare script May 7, 2026

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from 3a10697 to e819c1e Compare May 7, 2026 08:09

SoonIter marked this pull request as ready for review May 7, 2026 08:45

Copilot AI review requested due to automatic review settings May 7, 2026 08:45

Copilot started reviewing on behalf of SoonIter May 7, 2026 08:46 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread skills-lock.yaml Outdated

Comment thread .prettierignore Outdated

Comment thread package.json Outdated

Copilot AI review requested due to automatic review settings May 8, 2026 10:05

Copilot started reviewing on behalf of SoonIter May 8, 2026 10:20 View session

Copilot AI reviewed May 8, 2026

chenjiahan reviewed May 8, 2026

View reviewed changes

Comment thread .agents/skills/docs-en-improvement/SKILL.md

SoonIter mentioned this pull request May 15, 2026

feat: add local skill protocol SoonIter/skills-package-manager#32

Merged

2 tasks

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from 5bc0a08 to 91628ea Compare May 15, 2026 10:52

Copilot AI review requested due to automatic review settings May 18, 2026 03:17

Copilot started reviewing on behalf of SoonIter May 18, 2026 03:17 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread package.json

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from 9ead4b8 to 58d649d Compare May 18, 2026 03:50

Copilot AI review requested due to automatic review settings May 18, 2026 03:52

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from 58d649d to f4b230a Compare May 18, 2026 03:52

Copilot started reviewing on behalf of SoonIter May 18, 2026 03:52 View session

SoonIter marked this pull request as draft May 18, 2026 03:53

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from f4b230a to b2edd05 Compare May 18, 2026 03:54

Copilot AI reviewed May 18, 2026

View reviewed changes

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch 3 times, most recently from d68056c to bbad270 Compare May 18, 2026 06:04

SoonIter marked this pull request as ready for review May 18, 2026 07:50

Copilot AI review requested due to automatic review settings May 18, 2026 07:50

Copilot started reviewing on behalf of SoonIter May 18, 2026 07:50 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

SoonIter requested a review from chenjiahan May 18, 2026 08:20

chenjiahan reviewed May 18, 2026

View reviewed changes

Comment thread .prettierignore Outdated

SoonIter commented May 18, 2026

View reviewed changes

Comment thread cspell.config.js Outdated

SoonIter marked this pull request as draft June 15, 2026 06:37

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from b718034 to 35fa2b7 Compare June 15, 2026 07:23

chore: update skills package manager

9b35f23

SoonIter force-pushed the wip/trapped-yttrium-6d38 branch from 35fa2b7 to 9b35f23 Compare June 15, 2026 07:50

SoonIter added 5 commits June 15, 2026 16:36

chore: use gitignore for cspell

9a00ab2

chore: remove unused prettierignore

4c9a1d9

chore: restore skill headings

87eff18

chore: sync skills gitignore

e7d9fa1

chore: simplify skills gitignore

760ffb1

Uh oh!

Conversation

SoonIter commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Links

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SoonIter commented Apr 28, 2026 •

edited

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading