refactor: migrate lib.autoExternal to output.autoExternal

packages/core/src/cli/init.ts

@@ -117,9 +117,9 @@ export const applyCliOptions = (
     if (options.dts !== undefined) lib.dts = options.dts;
     if (options.autoExtension !== undefined)
       lib.autoExtension = options.autoExtension;
-    if (options.autoExternal !== undefined)
-      lib.autoExternal = options.autoExternal;
     lib.output ??= {};
+    if (options.autoExternal !== undefined)
+      lib.output.autoExternal = options.autoExternal;
     if (options.target !== undefined)
       lib.output.target = options.target as RsbuildConfigOutputTarget;
     if (options.minify !== undefined) lib.output.minify = options.minify;

packages/core/src/config.ts

@@ -28,7 +28,6 @@ import { composeExeConfig } from './exe';
 import { composeEntryChunkConfig } from './plugins/EntryChunkPlugin';
 import { pluginCjsShims, pluginEsmRequireShim } from './plugins/shims';
 import type {
-  AutoExternal,
   BannerAndFooter,
   DeepRequired,
   ExcludesFalse,
@@ -56,7 +55,6 @@ import {
   isDirectory,
   isEmptyObject,
   isIntermediateOutputFormat,
-  isObject,
   nodeBuiltInModules,
   normalizeSlash,
   omit,
@@ -72,88 +70,6 @@ import {
 } from './utils/syntax';
 import { loadTsconfig } from './utils/tsconfig';
 
-const getAutoExternalDefaultValue = (
-  format: Format,
-  autoExternal?: AutoExternal,
-): AutoExternal => {
-  return autoExternal ?? isIntermediateOutputFormat(format);
-};
-
-export const composeAutoExternalConfig = (options: {
-  bundle: boolean;
-  format: Format;
-  autoExternal?: AutoExternal;
-  pkgJson?: PkgJson;
-  userExternals?: NonNullable<EnvironmentConfig['output']>['externals'];
-}): EnvironmentConfig => {
-  const { bundle, format, pkgJson, userExternals } = options;
-
-  // If bundle is false, autoExternal will be disabled
-  if (!bundle) {
-    return {};
-  }
-
-  const autoExternal = getAutoExternalDefaultValue(
-    format,
-    options.autoExternal,
-  );
-
-  if (autoExternal === false) {
-    return {};
-  }
-
-  if (!pkgJson) {
-    logger.warn(
-      'The `autoExternal` configuration will not be applied due to read package.json failed',
-    );
-    return {};
-  }
-
-  // User externals configuration has higher priority than autoExternal
-  // eg: autoExternal: ['react'], user: output: { externals: { react: 'react-1' } }
-  // Only handle the case where the externals type is object, string / string[] does not need to be processed, other types are too complex.
-  const userExternalKeys =
-    userExternals && isObject(userExternals) ? Object.keys(userExternals) : [];
-
-  const externalOptions = {
-    dependencies: true,
-    optionalDependencies: true,
-    peerDependencies: true,
-    devDependencies: false,
-    ...(autoExternal === true ? {} : autoExternal),
-  };
-
-  const externals = (
-    [
-      'dependencies',
-      'peerDependencies',
-      'devDependencies',
-      'optionalDependencies',
-    ] as const
-  )
-    .reduce<string[]>((prev, type) => {
-      if (externalOptions[type]) {
-        return pkgJson[type] ? prev.concat(Object.keys(pkgJson[type])) : prev;
-      }
-      return prev;
-    }, [])
-    .filter((name) => !userExternalKeys.includes(name));
-
-  const uniqueExternals = Array.from(new Set(externals));
-
-  return externals.length
-    ? {
-        output: {
-          externals: [
-            // Exclude dependencies, e.g. `react`, `react/jsx-runtime`
-            ...uniqueExternals.map((dep) => new RegExp(`^${dep}($|\\/|\\\\)`)),
-            ...uniqueExternals,
-          ],
-        },
-      }
-    : {};
-};
-
 export function composeMinifyConfig(config: LibConfig): EnvironmentConfig {
   const minify = config.output?.minify;
   const format = config.format;
@@ -406,6 +322,7 @@ const composeFormatConfig = ({
         plugins: [modifyRsbuildDefaultPlugin({ disableUrlParse: true })],
         output: {
           filenameHash: false,
+          ...(bundle && { autoExternal: true }),
         },
         tools: {
           rspack: {
@@ -451,6 +368,7 @@ const composeFormatConfig = ({
         output: {
           module: false,
           filenameHash: false,
+          ...(bundle && { autoExternal: true }),
         },
         tools: {
           rspack: {
@@ -1476,7 +1394,7 @@ const composeDtsConfig = async (
   format: Format,
   dtsExtension: string,
 ): Promise<EnvironmentConfig> => {
-  const { autoExternal, banner, footer, redirect } = libConfig;
+  const { banner, footer, redirect } = libConfig;
 
   let { dts } = libConfig;
 
@@ -1499,7 +1417,10 @@ const composeDtsConfig = async (
         build: dts?.build,
         abortOnError: dts?.abortOnError,
         dtsExtension: dts?.autoExtension ? dtsExtension : '.d.ts',
-        autoExternal: getAutoExternalDefaultValue(format, autoExternal),
+        autoExternal:
+          libConfig.output?.autoExternal ??
+          libConfig.autoExternal ??
+          isIntermediateOutputFormat(format),
         alias: dts?.alias,
         isolated: dts?.isolated,
         banner: banner?.dts,
@@ -1653,13 +1574,13 @@ async function composeLibRsbuildConfig(
     banner = {},
     footer = {},
     autoExtension = true,
-    autoExternal,
     externalHelpers = false,
     redirect = {},
     umdName,
     experiments = {},
   } = config;
   const hasExe = Boolean(experiments.exe);
+
   const { rsbuildConfig: bundleConfig } = composeBundleConfig(bundle);
   const { rsbuildConfig: shimsConfig, enabledShims } = composeShimsConfig(
     format,
@@ -1726,13 +1647,7 @@ async function composeLibRsbuildConfig(
     config?.syntax,
     pkgJson,
   );
-  const autoExternalConfig = composeAutoExternalConfig({
-    bundle,
-    format,
-    autoExternal: hasExe ? false : autoExternal,
-    pkgJson,
-    userExternals,
-  });
+
   const cssConfig = composeCssConfig(
     outBase,
     cssModulesAuto,
@@ -1772,7 +1687,6 @@ async function composeLibRsbuildConfig(
     //    it relies on other externals config to bail out the externalized modules first then resolve
     //    the correct path for relative imports.
     userExternalsConfig,
-    autoExternalConfig,
     targetExternalsConfig,
     bundlelessExternalConfig,
     // #endregion
@@ -1820,11 +1734,33 @@ export async function composeCreateRsbuildConfig(
   }
 
   const libConfigPromises = libConfigsArray.map(async (libConfig, index) => {
+    if (libConfig.autoExternal !== undefined) {
+      logger.warn(
+        `${color.yellow('lib.autoExternal')} is deprecated, use ${color.yellow('output.autoExternal')} instead.`,
+      );
+    }
+
     const userConfig = mergeRsbuildConfig<LibConfig>(
       sharedRsbuildConfig,
       libConfig,
     );
 
+    // Deprecation shim: migrate lib.autoExternal → output.autoExternal
+    if (
+      libConfig.autoExternal !== undefined &&
+      libConfig.output?.autoExternal === undefined
+    ) {
+      userConfig.output ??= {};
+      userConfig.output.autoExternal = libConfig.autoExternal;
+    }
+
+    // Exe bundles everything into a single binary, so disable automatic externals
+    // after user config is merged to prevent users from re-enabling it.
+    if (userConfig.experiments?.exe) {
+      userConfig.output ??= {};
+      userConfig.output.autoExternal = false;
+    }
+
     // Merge the configuration of each environment based on the shared Rsbuild
     // configuration and Lib configuration in the settings.
     const libRsbuildConfig = await composeLibRsbuildConfig(

packages/core/src/types/config.ts

@@ -401,6 +401,7 @@ export interface LibConfig extends EnvironmentConfig {
   autoExtension?: boolean;
   /**
    * Whether to automatically externalize dependencies of different dependency types and do not bundle them.
+   * @deprecated Use `output.autoExternal` instead.
    * @defaultValue `true` when {@link format} is `cjs` or `esm`, `false` when {@link format} is `umd` or `mf`.
    * @see {@link https://rslib.rs/config/lib/auto-external}
    */
@@ -521,6 +522,11 @@ interface RslibOutputConfig extends OutputConfig {
    * @see {@link https://rslib.rs/config/rsbuild/output#outputminify}
    */
   minify?: OutputConfig['minify'];
+  /**
+   * @override
+   * @default `true` for ESM/CJS, `false` for UMD/MF/IIFE
+   */
+  autoExternal?: OutputConfig['autoExternal'];
 }
 
 export interface RslibConfig extends RsbuildConfig, SharedLibConfig {

packages/core/tests/__snapshots__/config.test.ts.snap

@@ -324,14 +324,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
     ]
   },
   externals: [
-    /^@rsbuild\\/core($|\\/|\\\\)/,
-    /^rsbuild-plugin-dts($|\\/|\\\\)/,
-    /^@microsoft\\/api-extractor($|\\/|\\\\)/,
-    /^typescript($|\\/|\\\\)/,
-    '@rsbuild/core',
-    'rsbuild-plugin-dts',
-    '@microsoft/api-extractor',
-    'typescript',
     'assert',
     'assert/strict',
     'async_hooks',
@@ -387,7 +379,11 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
     'worker_threads',
     'zlib',
     /^node:/,
-    'pnpapi'
+    'pnpapi',
+    /^@rsbuild\\/core(?:$|[/\\\\])/,
+    /^rsbuild-plugin-dts(?:$|[/\\\\])/,
+    /^@microsoft\\/api-extractor(?:$|[/\\\\])/,
+    /^typescript(?:$|[/\\\\])/
   ],
   node: {
     __dirname: false,
@@ -1198,14 +1194,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
     ]
   },
   externals: [
-    /^@rsbuild\\/core($|\\/|\\\\)/,
-    /^rsbuild-plugin-dts($|\\/|\\\\)/,
-    /^@microsoft\\/api-extractor($|\\/|\\\\)/,
-    /^typescript($|\\/|\\\\)/,
-    '@rsbuild/core',
-    'rsbuild-plugin-dts',
-    '@microsoft/api-extractor',
-    'typescript',
     'assert',
     'assert/strict',
     'async_hooks',
@@ -1261,7 +1249,11 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
     'worker_threads',
     'zlib',
     /^node:/,
-    'pnpapi'
+    'pnpapi',
+    /^@rsbuild\\/core(?:$|[/\\\\])/,
+    /^rsbuild-plugin-dts(?:$|[/\\\\])/,
+    /^@microsoft\\/api-extractor(?:$|[/\\\\])/,
+    /^typescript(?:$|[/\\\\])/
   ],
   output: {
     devtoolModuleFilenameTemplate: '[relative-resource-path]',
@@ -4298,6 +4290,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
   "config": {
     "output": {
       "assetPrefix": "auto",
+      "autoExternal": true,
       "dataUriLimit": 0,
       "distPath": {
         "css": "./",
@@ -4306,14 +4299,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
         "jsAsync": "./",
       },
       "externals": [
-        /\\^@rsbuild\\\\/core\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        /\\^rsbuild-plugin-dts\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        /\\^@microsoft\\\\/api-extractor\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        /\\^typescript\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        "@rsbuild/core",
-        "rsbuild-plugin-dts",
-        "@microsoft/api-extractor",
-        "typescript",
         "assert",
         "assert/strict",
         "async_hooks",
@@ -4570,6 +4555,7 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
   "config": {
     "output": {
       "assetPrefix": "auto",
+      "autoExternal": true,
       "dataUriLimit": 0,
       "distPath": {
         "css": "./",
@@ -4578,14 +4564,6 @@ exports[`Should compose create Rsbuild config correctly > Merge Rsbuild config i
         "jsAsync": "./",
       },
       "externals": [
-        /\\^@rsbuild\\\\/core\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        /\\^rsbuild-plugin-dts\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        /\\^@microsoft\\\\/api-extractor\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        /\\^typescript\\(\\$\\|\\\\/\\|\\\\\\\\\\)/,
-        "@rsbuild/core",
-        "rsbuild-plugin-dts",
-        "@microsoft/api-extractor",
-        "typescript",
         "assert",
         "assert/strict",
         "async_hooks",

packages/core/tests/cli.test.ts

@@ -170,7 +170,7 @@ describe('applyCliOptions', () => {
     expect(lib.bundle).toBe(false);
     expect(lib.dts).toBe(true);
     expect(lib.autoExtension).toBe(false);
-    expect(lib.autoExternal).toBe(false);
+    expect(lib.output?.autoExternal).toBe(false);
     expect(lib.syntax).toEqual(['node 18']);
     expect(lib.source?.tsconfigPath).toBe('./tsconfig.build.json');
     expect(lib.source?.entry).toEqual({