Skip to content

Feature: Magic Remote now supports scroll-based video seeking#324

Open
jesvijonathan wants to merge 1 commit into
webosbrew:mainfrom
jesvijonathan:remote-seek-feature
Open

Feature: Magic Remote now supports scroll-based video seeking#324
jesvijonathan wants to merge 1 commit into
webosbrew:mainfrom
jesvijonathan:remote-seek-feature

Conversation

@jesvijonathan

Copy link
Copy Markdown

You can seek videos via Magic-Remote's scroll wheel with logic to not hinder video list scroll functionalities.

This means you can seek a video without having to spam the arrow button on your remote

@jesvijonathan

jesvijonathan commented Aug 18, 2025

Copy link
Copy Markdown
Author

Add it to v0.5 milestone

@jesvijonathan

Copy link
Copy Markdown
Author

@throwaway96

Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js Outdated
Comment thread src/scroll-seek-controls.js
Comment thread src/scroll-seek-controls.js Outdated
@jesvijonathan jesvijonathan force-pushed the remote-seek-feature branch 2 times, most recently from bb364c2 to 6832dad Compare August 21, 2025 18:57
@jesvijonathan jesvijonathan reopened this Aug 21, 2025
@jesvijonathan jesvijonathan requested a review from fire332 August 21, 2025 19:13
@jesvijonathan

Copy link
Copy Markdown
Author

hey @fire332

@fire332 fire332 force-pushed the remote-seek-feature branch from cd2487d to 3e893e5 Compare October 2, 2025 13:40
@fire332

fire332 commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Rebased your branch on the current main and tested it. It would be nice if scrolling with the player controls hidden brought them up and focused them. Currently, it only brings up the controls without focus.

@fire332 fire332 removed their request for review October 2, 2025 15:11
@jesvijonathan

jesvijonathan commented Oct 2, 2025

Copy link
Copy Markdown
Author

Rebased your branch on the current main and tested it. It would be nice if scrolling with the player controls hidden brought them up and focused them. Currently, it only brings up the controls without focus.

First scroll brings the controls up, second scroll immediately triggers the scroll action.. (just incase not to accidentally trigger, this is only if player control is hidden)
Give it a shot

@fire332

fire332 commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

It does not. First scroll does indeed bring the controls up, but second scroll does nothing. I have to manually focus the seek bar before scrolling actually seeks.

@fire332 fire332 added the enhancement New feature or request label Oct 10, 2025
@rogacz1988

Copy link
Copy Markdown

Its not working. I have similar issue which have @fire332

@jesvijonathan

jesvijonathan commented Oct 15, 2025

Copy link
Copy Markdown
Author

@fire, just tested... its working just as i mentioned.

https://youtube.com/shorts/qqXfloEXxE4?si=cU4oLPNogneR7yJt

Also please do respond ASAP, I will be out of station next week onwards,
lets wrap this up this week

@jesvijonathan jesvijonathan requested a review from fire332 October 24, 2025 03:07
@adokitkat

Copy link
Copy Markdown

I wouldn't set this as enabled by default. At least not when not pointing directly at the timelilne. Nice feature though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants