Skip to content

Fix CI type error #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webstackdev merged 7 commits into from
Nov 4, 2025
Merged

Fix CI type error #446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2acf463
Fix CI type error
webstackdev Nov 4, 2025
17ac0b9
Move Sentry sourcemap generation to Vercel from GitHub Actions
webstackdev Nov 4, 2025
53986eb
Fix code and JSON lint errors
webstackdev Nov 4, 2025
d4ce81e
Fix mocking errors with upgrade to vitest
webstackdev Nov 4, 2025
cff24a7
Remove astro styling config plugin in favor of stylelint official plu…
webstackdev Nov 4, 2025
319d67a
Update stylelint config plugin, config settings, and fix style errors…
webstackdev Nov 4, 2025
2c72f32
Add lint tasks to Husky pre-commit hook
webstackdev Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .cache/pages.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/**
* Type declaration for generated pages.json file
* This file is generated during the build process
*/

type PageData =
| string
| { articles: string[] }
| { 'case-studies': string[] }
| { downloads: string[] }
| { services: string[] }
| { 'social-shares': string[] }
| { stories: string[] }
| { tags: string[] }
Comment on lines +6 to +14

Copilot AI Nov 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PageData type definition is too rigid with hardcoded property names. This forces type definition updates whenever new page categories are added. Consider using a more flexible type: type PageData = string | Record<string, string[]> to allow any category name.

Suggested change
type PageData =
| string
| { articles: string[] }
| { 'case-studies': string[] }
| { downloads: string[] }
| { services: string[] }
| { 'social-shares': string[] }
| { stories: string[] }
| { tags: string[] }
type PageData = string | Record<string, string[]>

Copilot uses AI. Check for mistakes.

declare const pagesData: PageData[]
export default pagesData
6 changes: 4 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ npm-debug.log*
# Optional eslint cache
.eslintcache

# Cache
.cache
# Cache - ignore all contents except type declarations and placeholder data
.cache/*
!.cache/*.d.ts
!.cache/pages.json

# Runtime data
pids
Expand Down
13 changes: 0 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,6 @@
"test": "NODE_ENV=test npm run test:unit && npm run test:e2e:ready",

Copilot AI Nov 4, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script test:e2e:ready is referenced in the main test script but has been removed. This will cause the test command to fail with 'missing script: test:e2e:ready' error. Either update this to use test:e2e or restore the test:e2e:ready script.

Suggested change
"test": "NODE_ENV=test npm run test:unit && npm run test:e2e:ready",
"test": "NODE_ENV=test npm run test:unit && npm run test:e2e",

Copilot uses AI. Check for mistakes.
"test:coverage": "NODE_ENV=test npx vitest run --coverage",
"test:e2e": "NODE_ENV=test npx playwright test",
"test:e2e:all": "NODE_ENV=test npx playwright test --grep-invert @blocked",
"test:e2e:debug": "NODE_ENV=test npx playwright test --debug",
"test:e2e:dev": "NODE_ENV=test DEBUG=true npx playwright test",
"test:e2e:dev:headed": "NODE_ENV=test DEBUG=true npx playwright test --headed",
"test:e2e:dev:smoke": "NODE_ENV=test DEBUG=true npx playwright test test/e2e/specs/01-smoke",
"test:e2e:dev:ui": "NODE_ENV=test DEBUG=true npx playwright test --ui",
"test:e2e:headed": "NODE_ENV=test npx playwright test --headed",
"test:e2e:list": "NODE_ENV=test npx playwright test --list",
"test:e2e:ready": "NODE_ENV=test npx playwright test --grep @ready",
"test:e2e:report": "npx playwright show-report .cache/playwright/reports",
"test:e2e:smoke": "NODE_ENV=test npx playwright test test/e2e/specs/01-smoke",
"test:e2e:ui": "NODE_ENV=test npx playwright test --ui",
"test:e2e:wip": "NODE_ENV=test npx playwright test --grep @wip",
"test:unit": "NODE_ENV=test npx vitest run",
"upgrade": "npx @astrojs/upgrade",
"prepare": "husky"
Expand Down
Loading