Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a633a41e95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0d3a67127
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76e725a5f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 819f4bfe6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b877b44a7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c538ef16ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b797a2911
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34262b8a0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8657bf7c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87a2538bee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86042b85d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a9a9c4b6d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Advanced styles now let users edit property names inline, add a declaration at the + insertion line, and enter several declarations with Shift+Enter or a multiline paste. Tab from a value, or Enter with the caret at its end, starts a new property/value row. Shift+Enter in a value grows its highlighted editor in place.
The Style Panel menu selects Default, Focus, or Advanced mode. The Advanced section menu offers Open editor, Code view, Pin section, and declaration actions. Code view and Pin section are off by default and saved locally. Code view shows editable declarations from the selected style block without inherited declarations or search. Pin section keeps the Advanced section at the bottom of the scrolling Style Panel. Open editor shows the centered Style block editor and is also available with Option+Shift+X. Copy, paste, and delete declaration actions remain in the declaration context menu. The editor marks invalid declarations, selectors, and at-rules; unsupported new input is omitted when it closes. Existing declarations with rejected edits keep their saved values. Values containing uploaded assets or hidden parts cannot be overwritten through CSS text.
Add inline property editing and keyboard insertion
Add multiline declaration and value editing
Move the + button to the insertion line
Disable unavailable context-menu actions
Open the centered Style block editor from the section maximize button
Show declaration issues in the editor and safely apply valid changes
Update the inline editor browser check and style-panel end-to-end checks
Add the approved + insertion-line documentation
Verify Builder and design-system typechecks, targeted lint, formatting, and diff checks
Verify all required PR checks, including Builder browser tests and every end-to-end shard
Reuse the section header button for the Advanced styles insertion line
Verify keyboard access and required PR checks after the button change
Review documentation impact for the button change
Accept valid Firefox font smoothing values in the block editor
Limit block editor diagnostics to affected declarations
Review documentation impact for the parser/diagnostic change
Verify required PR checks for the parser/diagnostic change
Delete an editable declaration when Enter submits an empty property name
Close a new draft when Enter submits its empty property name
Review documentation impact for the empty-name behavior
Verify required PR checks for the empty-name behavior
Replace the Advanced header maximize button with an ellipsis menu
Reuse copy, paste, and delete declaration actions in both menus
Preserve the centered Style block editor behind Open editor
Update the approved Advanced documentation sentence
Review the menu behavior and verify required PR checks
Add a saved Code mode toggle, off by default
Render the same Style block editor inline for local declarations
Review inline editing and verify required PR checks
Remove the Navigator CSS preview and its outdated references
Verify removal and required PR checks
Review branch editing and validation for reuse and consistency
Prevent inline Code mode drafts from deleting concurrent changes
Diagnose invalid shorthand values in Code mode
Keep row drafts scoped to the selected style block
Accept valid shorthand properties in new property/value rows
Preserve multiline add drafts when their anchor moves
Rename the Advanced menu toggle to Code mode and separate declaration actions
Review documentation impact for this change (no docs mention the old label)
Verify required PR checks for this change
Align Advanced menu action labels with the checkbox rows
Review documentation impact for menu spacing (no copy change)
Verify required PR checks for menu spacing
Add a saved Sticky toggle for the Advanced section
Use the shared section background token for every section container
Verify sticky behavior and required PR checks
Resolve open PR review comments and verify earlier fixes
Preserve saved variable fallbacks when Tab starts a new declaration
Keep invalid Code mode text visible after valid declarations apply
Review documentation impact of review fixes
Verify required PR checks for review fixes
Make the inline Advanced Code mode editor transparent
Review documentation impact for the background change
Verify required PR checks for the background change
Restore property and property:value autocomplete in the new declaration row
Preserve property:value suggestions when filling the new declaration row
Review documentation impact for autocomplete
Verify required PR checks for autocomplete
Review the full PR for correctness, reuse, and simplification
Fix verified review findings and reduce redundant code
Review documentation impact of review fixes
Verify required PR checks for review fixes
Move mode, Code view, Sticky advanced section, and Open editor into the Style Panel menu
Open the centered editor with Option+Shift+X from the global shortcut system
Remove the Advanced section dropdown and its unused menu actions
Review and update Advanced documentation for the new menu and shortcut
Verify the menu, shortcut, and required PR checks
Reuse property autocomplete while editing saved declaration names
Keep rename validation, duplicate protection, and keyboard focus behavior
Review documentation impact of saved-property autocomplete
Verify the change and required PR checks
Preserve hidden keyframe transforms when deleting visible CSS declarations
Hide shorthand suggestions while renaming a saved property
Review documentation impact for these fixes
Verify the fixes and required PR checks
Keep an animation popover open while its context menu is used
Review documentation impact of the animation context-menu fix
Type colon in a new property to focus its value field
Paste a declaration into the property field to fill property and value
Preserve multi-declaration paste behavior and review documentation impact
Preview highlighted property:value suggestions in the new row and clear the preview
Restore CSS variable name errors and duplicate warnings in the new row
Review documentation impact of suggestion preview and validation
Use the shared + property/value entry in animation settings
Review animation entry documentation impact
Replace the older Add styles documentation paragraph after wording approval (deferred at the user's request)
The Navigator CSS preview, its dead highlighter, and outdated documentation are removed. The older Add styles paragraph remains unchanged at the user's request and no longer describes the entry path accurately. The header menu and its approved documentation sentence are updated. Local tests and Storybook screenshots were not run. Builder and CSS data typechecks, targeted lint, formatting, and diff checks passed. A browser-like diagnostic accepted
-moz-osx-font-smoothing: grayscaleand rejected an invalid value. The new validation and diagnostic changes add 18 net non-test lines; they do not affect fixture inputs or outputs. The empty-name Enter change adds 23 non-test lines and does not affect fixtures or user-facing copy. Builder typecheck, targeted lint, formatting, and diff checks passed. All required PR checks passed on04bdaa955c, including all ten Builder end-to-end shards. The header menu and Code mode passed local Builder typecheck, targeted lint, formatting, and diff checks; all 38 checks on7ce09a5d32completed (37 passed, one visual job skipped). The sticky option passed local Builder typecheck, targeted lint, formatting, and diff checks. The first visual job found a Dashboard sidebar change from the shared section background; the background is now scoped to the Style Panel. All 36 checks onec24571859completed (35 passed, one skipped), including the visual check and all ten Builder end-to-end shards. Builder core passed on its retry after the first job reached its seven-minute time limit. The Navigator removal passed local Builder typecheck, targeted lint, formatting, and diff checks. All 36 checks on36b3a39979completed (35 passed, one visual job skipped), including all ten Builder end-to-end shards. The branch-wide review found and fixed five editing consistency and data-loss issues: invalid shorthands now use shared validation in both modes; inline Code mode keeps its original save baseline while dirty; row drafts reset when the style scope changes; valid shorthand names open the new property/value row; and multiline drafts retain their text and caret when their anchor moves. An unused EditorPopover wrapper was removed. The review fixes add 50 net non-test lines. Builder typecheck, targeted lint, formatting, and diff checks passed locally. The review also found that saving the first declaration could change the selected style source while leaving its add draft open; the draft is now scoped to the full selection. All 34 checks on53f6c4493fcompleted (33 passed, one skipped), including all ten Builder end-to-end shards. The Advanced menu spacing adds 8 net non-test lines and does not change product copy or fixture data. Builder typecheck, targeted lint, formatting, and diff checks passed. All 36 checks on3d9194280fcompleted (35 passed, one skipped); end-to-end shard 10 passed on retry after an unrelated form submission assertion failed on its first run. The inline mode adds 116 net non-test lines because it shares the dialog parser and editor while keeping the inline draft during editing and synchronizing changes from the selected style block.The review follow-up preserves saved variable fallbacks on Tab and keeps invalid Code mode text visible after valid declarations apply. It adds 9 net non-test lines, changes no product copy or fixture inputs/outputs, and needs no documentation update. Builder typecheck, targeted lint, formatting, and diff checks passed locally. All 34 required checks on
cb6217e0c0completed (33 passed, one skipped), including all ten Builder end-to-end shards. All PR review threads are resolved.The inline Code mode background is transparent; the centered editor keeps its existing background. This adds one non-test line and changes no product copy or fixtures. Builder typecheck, targeted lint, formatting, and diff checks passed locally. All 36 required checks on
a121e100e3completed (35 passed, one skipped), including visual regression and all ten Builder end-to-end shards.The new property row now uses the existing Add styles suggestion list for property names and property:value combinations. Selecting a combination fills both fields for further editing. Escape closes an open suggestion menu while keeping focus in the property field. This adds 95 net non-test lines to connect the existing suggestion UI to the new row. The current documentation already describes property autocomplete; no copy or fixture changes are needed. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. All 36 required checks on
dce1cedc69completed (35 passed, one skipped), including visual regression and all ten Builder end-to-end shards.The final review removed unused editor APIs and dialog props and consolidated style block initialization. It reduced non-test code by 38 lines without changing visible behavior or product copy. The documentation needs no update for this cleanup. Local Builder and design-system typechecks, targeted lint, formatting, and diff checks passed. Local tests were not run. All 36 required PR checks on
efda26ed99completed (35 passed, one skipped), including every Builder end-to-end shard.The Style Panel menu change removes 43 net non-test lines. It keeps the saved setting keys and style data unchanged; fixture inputs and outputs are unaffected. The Advanced documentation now points to the Style Panel menu and the new shortcut. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. All 36 required PR checks on
f3d2ba07dccompleted (35 passed, one skipped), including all ten Builder end-to-end shards.Saved property names now use the same suggestions and descriptions as new property rows. Selecting a property:value suggestion updates the saved value; choosing a different property still checks for duplicates and validates the value. The current Advanced documentation already describes autocomplete, so it needs no copy change. This change adds 69 net non-test lines after sharing the suggestion menu. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. The first CI run found an Escape regression; the follow-up restores the original reset behavior. All 34 checks on
fc337113e8completed (33 passed, one skipped), including Builder app tests and all ten end-to-end shards.The review follow-up makes keyframe deletion act only on the visible CSS declarations and disables it when none are deletable. Saved-name autocomplete now omits shorthands because a rename stores one declaration. The unused delete-all override is removed. This adds four net non-test lines and changes no product copy, docs, or fixture inputs. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests were not run. All 36 required checks on
b7fe3e9508completed (35 passed, one skipped), including the Builder app suite and all ten end-to-end shards.Show inherited and preset CSS below the inline Advanced editor in Code view
Review documentation impact of the Code view preview
Verify the Code view preview and check the final diff
Restore Advanced section menu and leave only panel modes in the top menu
Rename the saved sticky toggle to Pin section
Review and update documentation for the restored menu
Verify menu behavior and final diff
Move multiline declaration entry into the reusable property/value row
Remove the legacy Add styles component and its visibility state
Preserve declaration paste, completion, autocomplete, and variable feedback
Review documentation impact and final non-test line count
Verify the changed Builder code and required PR checks
Add saved visibility controls for read-only Code view sources
Replace source comments with headings and let inline sections fully expand
Review Advanced style documentation for these controls
Verify the updated Builder code and required PR checks
Reuse property and value suggestion data in Code view and the centered editor
Keep declaration completion scoped to the CSS block
Review Advanced documentation for Code view autocomplete
Verify the updated Builder code and required PR checks
Keep the caret stable while editing multiline declaration drafts
Avoid duplicate colons when completing existing property names
Review documentation impact and verify the review fixes
The latest review fixes preserve the caret while editing earlier lines in a multiline declaration draft and keep the existing colon when completing a saved property name in Code view. They add five net non-test lines, with no product copy, documentation, or fixture changes. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. All required PR workflows passed on
4f78d747f8, including all ten Builder end-to-end shards and the approved visual run. Builder core passed on retry after its first job was canceled while still running.A partial property name on a line between declarations now receives property suggestions in Code view and the centered editor. The CSS parser had treated that unfinished line as a selector; completion now recognizes it as a new declaration line. This adds eight net non-test lines and changes no product copy or fixture data, so the existing Advanced documentation still applies. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. All required PR workflows passed on
f3c7d6945b, including all ten Builder end-to-end shards and the approved visual run. The reported invisible caret was reproduced in the CSS Editor Storybook story on this Mac and fixed in01e9567aea. CodeMirror positioned its 1 px caret just outside the clipped scroll area at the start of a line. Its cursor now stays within that area. Shift+Enter also preserves a value that the input auto-selected on focus. Storybook captures at 320 px and 640 px in light and dark themes show the caret immediately after Shift+Enter. Builder typecheck, targeted lint, formatting, and diff checks passed locally. No local test suite was run. The change adds nine net non-test lines. All required PR checks on01e9567aeapassed, including all ten Builder end-to-end shards and the approved visual rerun. The initial visual comparison showed only the previously reviewed + insertion line.Closes #6470
The animation popover now ignores the animation list’s right-click and context-menu interactions while retaining ordinary outside-click dismissal. This adds 19 net non-test lines and changes no product copy or fixture data. The animation documentation does not describe context-menu dismissal, so no documentation edit is needed. Builder and design-system typechecks, targeted lint, formatting, and diff checks passed locally. Local UI verification and tests were not run. All 36 PR checks on
8184d1bbefcompleted (35 passed, one skipped), including all ten Builder end-to-end shards.The new property row now treats a typed colon as the separator and focuses the value field without inserting the colon. Single-line declaration paste fills both fields; multiline paste still opens the highlighted declaration editor. The split uses CSS tokens so colons inside values remain intact. This changes no product copy or fixture inputs/outputs. The Advanced documentation already discusses declaration entry, and its older Add styles paragraph remains deferred at the user's request. Builder typecheck, targeted lint, formatting, and diff checks passed locally. No tests or UI interaction check were run; this change was pushed in
275f6c3955; all 36 PR checks completed (35 passed, one skipped), including all ten Builder end-to-end shards.The new declaration row previews highlighted property:value suggestions and clears the preview when the highlight changes, focus leaves, the draft closes, or the component unmounts. CSS variable names now use the older input's error and duplicate-warning behavior. This adds no new product copy or fixture changes, and the existing autocomplete documentation covers the behavior. Builder typecheck, targeted lint, formatting, and diff checks passed locally. No tests or UI interaction check were run; these changes were pushed in
275f6c3955; all 36 PR checks completed (35 passed, one skipped), including all ten Builder end-to-end shards.The animation settings editor now uses the same + insertion line and property/value draft as Advanced styles.
CssEditormanages this draft locally for animation settings; Advanced styles keeps its existing controlled selection behavior. This removes the visible legacy Add styles field from that animation call site without changing stored animation data or product copy. The animations documentation does not describe that field, so no documentation edit is needed. Builder typecheck, targeted lint, formatting, and diff checks passed locally. No tests or UI interaction check were run; this change was pushed in275f6c3955; all 36 PR checks completed (35 passed, one skipped), including all ten Builder end-to-end shards.Code view now shows a read-only CSS preview of cascaded and preset styles below the editable block. The preview includes inherited values from ancestor instances and other style sources; browser defaults and overridden values are not listed. It reuses the CodeMirror syntax colors without changing stored style data. The existing Advanced documentation has no Code view preview instructions to revise. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and UI interaction checks were not run. All 36 PR checks on
5839693c13completed (35 passed, one skipped), including all ten Builder end-to-end shards.The Advanced section menu is restored with Open editor, Code view, Pin section, Copy declarations, Paste declarations, and Delete declarations. The top Style Panel menu contains only Default, Focus, and Advanced mode. The saved setting keys and Option+Shift+X shortcut are unchanged. The Advanced documentation now points to the section menu. No fixture inputs or outputs changed. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and UI interaction checks were not run. All 36 PR checks on
4f0c40450dcompleted (35 passed, one skipped), including all ten Builder end-to-end shards.The legacy Add styles input is deleted. The reusable property/value row now opens its own highlighted declaration editor for Shift+Enter and multiline paste. The autocomplete helpers remain in
property-autocomplete.tsx; the old visibility state and input-specific tests are removed, while the shared row tests remain. This removes 447 net non-test lines and does not change fixture inputs or outputs. The older Add styles documentation paragraph stays unchanged under the user's earlier direction and is now outdated; its update remains deferred in the unchecked documentation item above. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and UI interaction checks were not run. All required PR workflows on86042b85d7completed successfully, including every Builder end-to-end shard. The first visual comparison flagged the intended + insertion line in the CSS Editor story; its screenshot was reviewed, approved withvisual-change-approved, and the visual rerun passed.Code view now has saved Show cascaded and Show preset controls, both off by default. Local, Cascaded, and Preset CSS have separate headings, and the inline editors have no maximum height so the Style Panel scrollbar handles long blocks. The centered dialog retains its own sizing. The approved documentation sentence was added; the older Add styles paragraph remains deferred at the user's request. This adds 57 net non-test lines. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. All required PR workflows on
14f197c2ffcompleted successfully, including all ten Builder end-to-end shards. The visual baseline still shows the old Add styles input; its single difference is the previously reviewed + insertion line. The approved rerun passed.The inline and centered Style block editors now suggest the same property names, property:value combinations, property-specific keyword values, and available CSS variables as the UI rows. The completion source uses declaration-list syntax, so it does not offer selectors or at-rules. The existing Advanced documentation already describes autocomplete and no new product copy or fixture input changed. This adds 98 net non-test lines. Builder typecheck, targeted lint, formatting, and diff checks passed locally. Local tests and Storybook screenshots were not run. All required PR workflows on
1a9a9c4b6dcompleted successfully, including every Builder end-to-end shard. The first visual run flagged only the previously approved + insertion line; its image was identical to the reviewed screenshot, and the approved visual rerun passed.