Repository navigation
chore: bump kubedog to stop leaking informers after tracking - #812
Merged
Merged
Conversation
Pins werf/kubedog f1eefb5 on its `0` branch (werf/kubedog#407, backport of #406): informers are released after tracking ends. The range also brings werf/kubedog#405, which keeps the legacy uninstall wait from hanging with WatchListClient and from missing a deletion between LIST and WATCH. Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
Contributor
Author
Verification
Review focus
Follow-up
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A long-lived process that runs a nelm release install with tracking on every reconcile (for example a controller embedding nelm v1) keeps shared informers alive after each tracking ends, each holding the cache of a resource type for a whole namespace, so memory grows until the process restarts. This bumps
github.com/werf/kubedogfromad1e8a1tof1eefb5on kubedog's0branch, which releases those informers (werf/kubedog#407, backport of werf/kubedog#406). The range also brings werf/kubedog#405, which fixes the resource elimination wait of the legacyrelease uninstallpath.What
go.mod/go.sum:github.com/werf/kubedogv0.13.1-0.20260912145640-ad1e8a134607→v0.13.1-0.20261103161329-f1eefb59d19a; no other module changes.ad1e8a1..f1eefb5is two commits: fix(elimination): stop hanging when WatchListClient is enabled kubedog#405 and fix: stop leaking informers and their caches after tracking ends kubedog#407.Tracking during
release install/release rollback/ nativerelease uninstall(werf/kubedog#407)main(38643e9) is not part of kubedog's0branch and does not come with this bump.Resource elimination wait in the legacy uninstall path (werf/kubedog#405)
nelm release uninstallwithoutNELM_FEAT_NATIVE_RELEASE_UNINSTALL/NELM_FEAT_PREVIEW_V2, and toaction.LegacyReleaseUninstallcallers, at theWaiting for resources eliminationstep.WatchListClientfeature gate is on by default) no longer hangs atWaiting for resources eliminationuntil the timeout when the resources are already gone. nelm itself pins client-go v0.29.3, where the gate is off.Why
Kubedog's informer event handlers on
0sent to tracker channels without watching for cancellation. Once the tracker stopped reading, a handler blocked forever, so the stopped informer waited on it and never returned, keeping its namespace-wide cache referenced; in a process that deploys repeatedly this accumulated into gigabytes. The elimination tracker replaced the reflector's list/watch options with a bare field selector, dropping the resourceVersion and WatchList parameters, which caused both the missed deletion and the WatchList hang.BEGIN_COMMIT_OVERRIDE
fix: stop leaking informers and their caches after tracking
fix: stop resource elimination waiting from missing deletions and hanging when WatchListClient is enabled
END_COMMIT_OVERRIDE