fix: use unit IDs directly in Log.fromSetConfigData to prevent null on save - #1175
Merged
rolandgeider merged 1 commit intoApr 13, 2026
Conversation
…n save
When adding an extra exercise during a workout, addExerciseAfterPage()
creates a SetConfigData with no unit objects loaded. Log.fromSetConfigData
was using the weightUnit/repetitionUnit setters which overwrite the default
IDs with null when the objects are null, causing the server to reject the
request with a ValidationError ("Repetitions unit must be present").
Fixes wger-project#1149
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
looks good, thanks! Those weightUnit and repetitionUnit setters are a bit of a pain / fragile, we should probably refactor how those work when we merge wger-project/wger#2275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding an extra exercise during a workout, addExerciseAfterPage() creates a SetConfigData with no unit objects loaded. Log.fromSetConfigData was using the weightUnit/repetitionUnit setters which overwrite the default IDs with null when the objects are null, causing the server to reject the request with a ValidationError ("Repetitions unit must be present").
Fixes #1149
Proposed Changes
Related Issue(s)
Please check that the PR fulfills these requirements
dart format .)