Skip to content

refactor: Split argument parsing from Args creation#1755

Merged
davidlattimore merged 1 commit into
mainfrom
push-zwwoopwopqmu
Mar 24, 2026
Merged

refactor: Split argument parsing from Args creation#1755
davidlattimore merged 1 commit into
mainfrom
push-zwwoopwopqmu

Conversation

@davidlattimore
Copy link
Copy Markdown
Member

No description provided.

@davidlattimore davidlattimore changed the title refactor: Move setting jobserver and files_per_group to common area refactor: Move setting some CommonArgs fields out of ELF-specific area Mar 24, 2026
@davidlattimore davidlattimore changed the title refactor: Move setting some CommonArgs fields out of ELF-specific area refactor: Split argument parsing from Args creation Mar 24, 2026
Also, deduplicate some common code.
@davidlattimore
Copy link
Copy Markdown
Member Author

My initial motivation for doing this was that I want to be able to set a field on Args before the arguments get parsed. Specifically, I want to be able to set a callback that gets run when there are warnings. I think I got some nice deduplication in the process of doing this though.

@davidlattimore davidlattimore merged commit 7de5685 into main Mar 24, 2026
24 checks passed
@davidlattimore davidlattimore deleted the push-zwwoopwopqmu branch March 24, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant