Move evaluator and assigner to shared package#5
Merged
williamgrosset merged 1 commit intomainfrom Feb 28, 2026
Merged
Conversation
Promotes evaluateTargetingRules and assignVariants into @experiments/shared so both the decision-service and the upcoming React SDK can import from the same source of truth. Moves the corresponding unit tests alongside the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evaluateTargetingRulesandassignVariantsfromdecision-service/src/services/into@experiments/shared, so both the decision-service and the upcoming client-side React SDK can import rule evaluation and variant assignment from a single source of truth.assignVariantsfrom@experiments/sharedinstead of its local copy.evaluator.test.ts,assigner.test.ts) topackages/shared/test/.Changes
packages/shared/src/evaluator.tsdecision-service(import paths updated to local shared types)packages/shared/src/assigner.tsdecision-service(importsevaluateTargetingRuleslocally,getBucketand types from shared)packages/shared/src/index.tsevaluateTargetingRulesandassignVariantspackages/shared/test/evaluator.test.tsdecision-service/test/(import paths updated)packages/shared/test/assigner.test.tsdecision-service/test/(import paths updated)decision-service/src/routes/decide.tsassignVariantsfrom@experiments/sharedinstead of local../services/assigner.jsdecision-service/package.json--passWithNoTestsflag since all tests moved to sharedVerification