Visualizer arc tolerance#3127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when expanding arcs to be displayed in the visualizer we used a min segment length. This would cause a huge number of segments on larger arcs. With this change we use a choord tolerance. For large models with low curvature the chords barely deviates it will generate larger segments. For small models requires more subdivisions.
A test with a "normal" size model that was 200x200mm got 10x fewer segments without noticable differences.
Fixes: #2430
Fixes: #1477 (segment count went from 21632032 to 767032 segments)