Repository navigation
Conversation
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unread lifecycle event accepted before an in-place upgrade can disappear. In particular, a Jobs owner can lose a queued CANCEL and remain alive past its shutdown deadline, while a second CANCEL sent after the upgrade stops the same PID.
process.events()leavesRetainOnUpgradefalse, so the mailbox transfer classifies its topic as belonging to a retiring producer and discards the queued tail. Mark lifecycle subscriptions as retained, using the existing mailbox-transfer behavior already used byprocess.inbox()andprocess.listen(). No scheduler, producer-retirement algorithm, subscription API, or release metadata changes.The regression steps the real Lua process engine directly, without sleeps or a scheduler race. The old incarnation consumes one event and waits outside its lifecycle channel while CANCEL and EXIT remain unread. The replacement must receive those events in order exactly once, must not replay the consumed event, and must still accept a fresh lifecycle event. On the base commit the unread-event count is 0 instead of 2; with the fix the test passes.
Validation:
go test -race -short -count=1 -timeout 10m ./runtime/lua/modules/process ./runtime/lua/engine ./system/process ./system/topology ./service/supervisormake lint LINT_PACKAGES='./runtime/lua/modules/process'— 0 issues.The original Jobs shutdown test is timing-sensitive and can miss this ordering; the new Go regression forces it deterministically. This does not claim the Jobs performance-settings change introduced the defect. The full cross-platform CI suite still needs to run on this PR.
Draft for review by @skhaz. No Runtime release is requested here. KickSide #215 and #245 remain held until the upstream fix is reviewed, released, and qualified downstream.