Skip to content

fix: keep screen sharing when other videos are disabled [WPB-24273]#4713

Merged
saleniuk merged 4 commits intodevelopfrom
fix/keep-screen-sharings-when-other-videos-are-disabled
Apr 13, 2026
Merged

fix: keep screen sharing when other videos are disabled [WPB-24273]#4713
saleniuk merged 4 commits intodevelopfrom
fix/keep-screen-sharings-when-other-videos-are-disabled

Conversation

@saleniuk
Copy link
Copy Markdown
Contributor

@saleniuk saleniuk commented Apr 9, 2026

https://wearezeta.atlassian.net/browse/WPB-24273


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user disables other videos, screen sharing ones are also disabled.

Solutions

Changed the logic to keep screen sharings.
Used the new sort type to keep them on top of a list.
Simplified conditions inside ParticipantTile.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • start/join a group call
  • let others enable video and start screen sharing
  • disable other videos

Attachments (Optional)

Before After
Screen.Recording.2026-03-23.at.15.36.36.mp4
Screen_recording_20260409_180810.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.91%. Comparing base (26f7a18) to head (7a9125b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4713   +/-   ##
========================================
  Coverage    49.90%   49.91%           
========================================
  Files          602      602           
  Lines        20650    20650           
  Branches      3291     3291           
========================================
+ Hits         10306    10307    +1     
  Misses        9377     9377           
+ Partials       967      966    -1     
Files with missing lines Coverage Δ
...android/ui/calling/ongoing/OngoingCallViewModel.kt 95.23% <100.00%> (+0.68%) ⬆️
...alling/ongoing/participantsview/ParticipantTile.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd66c3...7a9125b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…arings-when-other-videos-are-disabled

# Conflicts:
#	app/src/test/kotlin/com/wire/android/ui/calling/OngoingCallViewModelTest.kt
#	kalium
@saleniuk saleniuk requested a review from yamilmedina April 13, 2026 08:41
@sonarqubecloud
Copy link
Copy Markdown

@saleniuk saleniuk enabled auto-merge April 13, 2026 15:35
@saleniuk saleniuk added this pull request to the merge queue Apr 13, 2026
Merged via the queue into develop with commit 09f6059 Apr 13, 2026
17 checks passed
@saleniuk saleniuk deleted the fix/keep-screen-sharings-when-other-videos-are-disabled branch April 13, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants