put strong connectivity check in config.SHORTCIRCUIT_SIA.#114
Open
Astrocytes120 wants to merge 2 commits into
Open
put strong connectivity check in config.SHORTCIRCUIT_SIA.#114Astrocytes120 wants to merge 2 commits into
Astrocytes120 wants to merge 2 commits into
Conversation
added 2 commits
December 15, 2023 17:19
wmayner
added a commit
that referenced
this pull request
Jun 26, 2026
Audit of the 16 open PRs against current main: every fix-type PR (#141 unflatten arg order, #134 np.log2 out=, #114 strong-connectivity short-circuit) is already resolved in 2.0, and the rest are moot or superseded (jsonify tolerance, ray/redis importorskip, 2-3 relation plot cap, pandas rename, old TPM/substrate PRs, benchmarking notebook). Nothing left to absorb; only the GitHub closes remain (maintainer step). Update the "Open PRs to Absorb" section and the P15 status lines. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012dtSzF2YgDjGpFC9mA47ve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Will advised, I changed the code in order to work in the SHORTCIRCUIT_SIA. As a result, it works in the same way as before, but let an user know the reason why the subsystem is trivial.
If you have the other advice for trivial cases, please let me know it.
It works like this:
tpm = np.array(
[
[1, 0, 0],
[1, 0, 0],
[1, 0, 0],
[1, 0, 0],
[1, 0, 0],
[1, 0, 0],
[1, 1, 1],
[1, 1, 1],
]
)
cm = np.array([
[0,0,0],
[0,1,1],
[0,1,1],
])
labels= ["A", "B","C"]
state0= (1,1,1)
For all possible subsystems,
┌────────────────────────────────────────┐
│ NullSystemIrreducibilityAnalysis │
│ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ │
│ Subsystem: A,B,C │
│ Φ: 0.0 │
│ CAUSE: (0,1,1) │
│ II_c: 1.0 │
│ EFFECT: (1,1,1) │
│ II_e: 2.0 │
│ Reasons: NOT_STRONGLY_CONNECTED │
└────────────────────────────────────────┘
Subsystem(B, C)
┌──────────────────────────────────┐
│ SystemIrreducibilityAnalysis │
│ ━━━━━━━━━━━━━━━━━━━━━━━ │
│ Subsystem: B,C │
│ Current state: (1,1) │
│ φ_s: 2.0 │
│ Normalized φ_s: 1.0 │
│ CAUSE: (1,1) │
│ II_c: 2.0 │
│ EFFECT: (1,1) │
│ II_e: 2.0 │
│ #(tied MIPs): 0 │
│ Partition: │
│ 2 parts: {B,C} │
│ [[0 1] │
│ [1 0]] │
└──────────────────────────────────┘
Subsystem(A)
┌─────────────────────────────────────┐
│ NullSystemIrreducibilityAnalysis │
│ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ │
│ Subsystem: A │
│ Φ: 0.0 │
│ CAUSE: (0) │
│ II_c: 0.0 │
│ EFFECT: (0) │
│ II_e: 0.0 │
│ Reasons: NO_CAUSE, NO_EFFECT │
└─────────────────────────────────────┘