Skip to content

Return a current revision from browser_open and report batch progress on act failures - #62

Merged
wolfiesch merged 3 commits into
mainfrom
fix/act-revision-and-partial-results
Oct 4, 2026
Merged

wolfiesch merged 3 commits into
mainfrom
fix/act-revision-and-partial-results

Conversation

@wolfiesch

Copy link
Copy Markdown
Owner

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T21:08:36.524907Z 20dd729 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20dd729989

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/extension/src/background.ts Outdated

@wolf-maintainer wolf-maintainer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 — the partial-batch reporting is focused and tested, but the open-settling path still has a fast-load event-delivery race that can return a stale revision.
Also fix the new ReturnType<> convention breach and cover the 10-second deadline branch deterministically.
Thanks for addressing both failure modes and documenting the resulting contracts.

Comment thread packages/extension/src/background.ts
Comment thread packages/extension/src/background.ts Outdated
Comment thread packages/extension/src/background.ts Outdated
@wolfiesch
wolfiesch merged commit 580dddb into main Oct 4, 2026
8 checks passed
@wolfiesch
wolfiesch deleted the fix/act-revision-and-partial-results branch October 4, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant