Translate post types to Swift #25056
Conversation
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30131 | |
| Version | PR #25056 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2cfc79a | |
| Installation URL | 2avgu0lg69us0 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30131 | |
| Version | PR #25056 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2cfc79a | |
| Installation URL | 5egj01rl6oam0 |
crazytonyli
force-pushed
the
core-data-mismatch-declarations
branch
from
13f529a to
3e0e4d9
Compare
crazytonyli
changed the title
Generated by 🚫 Danger |
|
|
||
| // A ReaderCard can have either a post, or a list of topics, but not both. | ||
| // Since this card has a post, we can confidently set `topics` to NULL. | ||
| if responds(to: #selector(getter: card)), let managedObjectContext, let firstCard = card?.first { |
There was a problem hiding this comment.
I'd double-check if this works, and check if it's needed in the first place and if there are ways to refactor it. I can't say I have a lot of confidence in these types of Swift and Objective-C interactions.
There was a problem hiding this comment.
Yep. I have double-checked. The responds(to:) in the new Swift code returns true, and the if branch is executed. I'm pretty certain the card is always available in practice. The original Objective-C code was introduced in #17117. Since the commit message mentioned migration, I thought I'd be extra careful here and keep the original code.
There was a problem hiding this comment.
Nice! I'm sure there is more similar stuff to remove. A lot of these methods were added to satisfy interfaces that were only ever used on regular (not Reader) posts.
| return content.isEmpty || content == emptyGBParagraph | ||
| } | ||
|
|
||
| public func contentPreviewForDisplay() -> String? { |
There was a problem hiding this comment.
(nit) It would be ideal to remove it. I don't think we need it for ReaderPost.
|
Description
It should be straightforward to review commits by commit.
You can test by editing posts & pages, viewing posts and comments in the Reader.