Repository navigation
Conversation
…listener throws process, processOne, processIf and processUntil swap the queue into a temporary list and dispatch from it. When a listener threw, the temporary list was destroyed by the unwinding and all the events that were not processed yet were lost. Now the event being dispatched is removed (its listeners were invoked, maybe partially, and dispatching it again would invoke them again), the remaining events are put back to the front of the queue in their original order, the processed buffers are recycled, waiting threads are notified, and the exception propagates to the caller. If the predictor of processIf/processUntil throws, no event is removed. Added unit tests and updated documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process, processOne, processIf and processUntil swap the queue into a temporary list and dispatch from it. When a listener threw, the temporary list was destroyed by the unwinding and all the events that were not processed yet were lost.
Now the event being dispatched is removed (its listeners were invoked, maybe partially, and dispatching it again would invoke them again), the remaining events are put back to the front of the queue in their original order, the processed buffers are recycled, waiting threads are notified, and the exception propagates to the caller. If the predictor of processIf/processUntil throws, no event is removed.
Added unit tests and updated documents.