Repository navigation
Conversation
…and dispatchers The copy/move constructors, assignment operators and swap of CallbackList, EventDispatcher, HeterCallbackList and HeterEventDispatcher read the other object without locking its mutex, so they raced with other threads that were adding or removing listeners on it, although the document says all public functions are thread-safe. Now the source is locked while it's copied or moved, and both objects are locked (in address order, to avoid dead lock) when assigning or swapping. EventQueue and HeterEventQueue inherit the fix. Assigning to a dispatcher while another thread dispatches on it is still not safe (the dispatching thread holds a pointer to a callback list the assignment replaces); this is pre-existing and now documented. Added DualLockGuard because std::lock requires try_lock, which SingleThreading::Mutex doesn't have. Added multi threading unit tests and updated documents.
Haititi
force-pushed
the
fix/lock-source-on-copy
branch
from
October 6, 2026 14:02
8318aff to
0fa3070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy/move constructors, assignment operators and swap of CallbackList, EventDispatcher, HeterCallbackList and HeterEventDispatcher read the other object without locking its mutex, so they raced with other threads that were adding or removing listeners on it, although the document says all public functions are thread-safe. Now the source is locked while it's copied or moved, and both objects are locked (in address order, to avoid dead lock) when assigning or swapping. EventQueue and HeterEventQueue inherit the fix.
Assigning to a dispatcher while another thread dispatches on it is still not safe (the dispatching thread holds a pointer to a callback list the assignment replaces); this is pre-existing and now documented.
Added DualLockGuard because std::lock requires try_lock, which SingleThreading::Mutex doesn't have. Added multi threading unit tests and updated documents.