Repository navigation
Conversation
The old SpinLock spun on test_and_set without any backoff, which keeps invalidating the cache line of the lock and burns the CPU when the lock is held for long or there are more threads than CPU cores. Now the waiting thread spins on a plain load and yields after a while. It also uses std::atomic<bool> instead of std::atomic_flag with ATOMIC_FLAG_INIT, which is deprecated in C++20. Added try_lock so SpinLock satisfies Lockable. Added unit tests and updated documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old SpinLock spun on test_and_set without any backoff, which keeps invalidating the cache line of the lock and burns the CPU when the lock is held for long or there are more threads than CPU cores. Now the waiting thread spins on a plain load and yields after a while. It also uses std::atomic instead of std::atomic_flag with ATOMIC_FLAG_INIT, which is deprecated in C++20. Added try_lock so SpinLock satisfies Lockable.
Added unit tests and updated documents.