Skip to content

Updated CI: actions/checkout v4, added sanitizer jobs #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Haititi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated CI: actions/checkout v4, added sanitizer jobs #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
os: [windows-latest, ubuntu-latest, macos-latest]
build-type: [Release]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Configure
run: |
Expand All @@ -21,4 +21,43 @@ jobs:
run: cmake --build build --config "${{ matrix.build-type }}" -j

- name: Run unit tests
run: cd build && ctest --build-config "${{ matrix.build-type }}" --progress --verbose
run: cd build && ctest --build-config "${{ matrix.build-type }}" --progress --verbose

# Debug build with sanitizers. AddressSanitizer and UndefinedBehaviorSanitizer must pass.
Sanitizers:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Configure
run: |
mkdir -p build
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-fsanitize=address,undefined -fno-omit-frame-pointer" -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=address,undefined" -B build -S tests

- name: Build Tests
run: cmake --build build -j

- name: Run unit tests
run: cd build && ctest --progress --verbose
env:
UBSAN_OPTIONS: print_stacktrace=1:halt_on_error=1
ASAN_OPTIONS: detect_leaks=1

# ThreadSanitizer is informative only. CallbackList::empty() and hasAnyListener() read shared data
# without locking on purpose (see the comments in the code), which ThreadSanitizer reports as data races.
ThreadSanitizer:
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4

- name: Configure
run: |
mkdir -p build
cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_FLAGS="-fsanitize=thread -fno-omit-frame-pointer" -DCMAKE_EXE_LINKER_FLAGS="-fsanitize=thread" -B build -S tests

- name: Build Tests
run: cmake --build build -j

- name: Run unit tests
run: cd build && ctest --progress --verbose