-
Notifications
You must be signed in to change notification settings - Fork 171
Improve error handling #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
============================================
+ Coverage 30.47% 30.48% +0.01%
Complexity 1020 1020
============================================
Files 134 134
Lines 13315 13320 +5
Branches 2566 2567 +1
============================================
+ Hits 4058 4061 +3
- Misses 8753 8754 +1
- Partials 504 505 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| */ | ||
| Role createRole(Role role) throws CharonException, ConflictException, NotImplementedException, BadRequestException; | ||
| Role createRole(Role role) throws CharonException, ConflictException, NotImplementedException, | ||
| BadRequestException, ForbiddenException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this introduce any behavioural change? Then we have to do a version bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far ForbiddenException was not thrown.
Now also throwing for the cases introduced in this effort.
Do we still need to consider this as a behavioural change?
Purpose
Add ForbiddenException to method signatures in interfaces and default implementations to handle cases where operations are forbidden. . This is needed as part of fine-grained scope validation. In the SCIM layer, fine-grained scope validation checks will be performed; if the scope is not available, the ForbiddenException will be thrown.
Similar PR:
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning