runtime: add memprofile attribution support#1905
Conversation
|
Verification update for commit 622e1e5:\n\n- Root cause: Linux CI could not reliably recover LLGo Go function names from libunwind for memory profile stack attribution; the profile saw frames like |
|
CI update for
At the time of this update, the remaining visible checks are queued macOS jobs; no new failure is showing on the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Resolved the latest merge conflict with xgo-dev/main (51d665e). The merge keeps main's generic/linkonce and BDWGC MemStats changes while preserving this PR's memprofile attribution instrumentation and heapsampling xfail removal.\n\nLocal verification:\n- go test -timeout 20m ./test/go/memprofile -count=1\n- go test -timeout 20m ./test/go -run 'Test(RuntimeMemProfileAttribution|RuntimeReadMemStatsAfterInitGC)' -count=1\n- (runtime module) go test -timeout 20m ./internal/runtime ./internal/lib/runtime -count=1\n- git diff --check |
|
Added focused coverage for the memprofile attribution instrumentation paths. Changes:
Local verification:
CI note: the previous |
0dea392 to
ebe87b0
Compare
Summary:
Dependency / merge order:
mainand resolve the expected conflicts.runtime/internal/lib/runtime/pprof_runtime_stub_llgo.go,runtime/internal/runtime/memprofile.go,runtime/internal/runtime/z_gc.go, andtest/goroot/xfail.yaml.Tests: