Guard against uint32 overflow in byte-block skip/read limit checks#914
Open
hyder365 wants to merge 1 commit into
Open
Guard against uint32 overflow in byte-block skip/read limit checks#914hyder365 wants to merge 1 commit into
hyder365 wants to merge 1 commit into
Conversation
FLAC__bitreader_skip_byte_block_aligned_no_crc and FLAC__bitreader_read_byte_block_aligned_no_crc both compute nvals*8 without overflow protection. Values large enough to overflow are unreachable through current callers (metadata block length is at most 24 bits), but the overflow would silently disable the limit enforcement. Pre-check the multiplication against UINT32_MAX/8 before computing nvals*8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLAC__bitreader_skip_byte_block_aligned_no_crc and
FLAC__bitreader_read_byte_block_aligned_no_crc both compute
nvals*8 without overflow protection. Values large enough to
overflow are unreachable through current callers (metadata block
length is at most 24 bits), but the overflow would silently disable
the limit enforcement. Pre-check the multiplication against
UINT32_MAX/8 before computing nvals*8.