Add base PHPStan configuration#21
Open
Steveb-p wants to merge 1 commit into
Open
Conversation
Supamiu
previously approved these changes
Jan 5, 2024
Contributor
Author
|
Give me a moment to do a proper rebase :) |
Contributor
|
Sure, thanks a lot for your contributions by the way ! 😄 |
Contributor
Author
Well, I do intend to make use of the library (initially used xivapi API, but got errors and tried to pinpoint the issue - seems like an old version is still running on xivapi.com). Now that I've seen the parser I'll probably rely on it instead. Going to put it into a Symfony 6 or 7 project (so also PHP8) and looking if it will work, and how much is needed to keep it updated. So yeah, I should be thanking you instead 😅 (Rebase is done and finished). |
Contributor
Author
|
@Supamiu everything is ready, if the PR is ok :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PHPStan static analysis library + Github workflow to launch those tests automatically.
Selected ruleset level is 5, which is the recommended value for catching all basic PHP code issues. You can see the rulesets here: https://phpstan.org/user-guide/rule-levels.
All existing issues are put into "baseline", except me changing the PHPDoc for the
Apifactory methods.A higher ruleset is available as needed (and usually recommended level is 7-8).
See:
for test results.