Fixed occasional NPE on selection change.#56
Open
davidmichaelkarr wants to merge 1 commit intoxored:masterfrom
Open
Fixed occasional NPE on selection change.#56davidmichaelkarr wants to merge 1 commit intoxored:masterfrom
davidmichaelkarr wants to merge 1 commit intoxored:masterfrom
Conversation
This deals with the unusual case of selecting something in the buffer and then emptying the buffer. The selection change listener fires around that point, but "getModule()" returns null (in some cases, apparently), causing the NPE when that happens.
Contributor
Author
|
Forgot to mention, this is for this issue: #55 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deals with the unusual case of selecting something in the buffer
and then emptying the buffer. The selection change listener fires
around that point, but "getModule()" returns null (in some cases,
apparently), causing the NPE when that happens.