descript: roundtrip descript/scheduler#44
Conversation
48fd73c to
2b101f7
Compare
guillon
left a comment
There was a problem hiding this comment.
Is there a possibility to make the LoopNest/LoopChild being even further redesigned into a single typical LoopNestTree structure, for instance with child/parent relationship?
bb527e4 to
e453e7d
Compare
Yeay done. With a generic tree structure |
e413af6 to
a3a86fd
Compare
b0ce0b1 to
c82295e
Compare
3960242 to
50e6dea
Compare
|
@qaco you seem to have a merge issue of some kind, there are commits from the main branch in your review:
|
guillon
left a comment
There was a problem hiding this comment.
[Father] Focused review on first 8 commits only (excluding the last 2). I found two actionable issues.
- Potential nondeterminism in dimension ordering
- In
LoopInfo.build_from_node, dimensions are accumulated in asetand returned aslist(dims). - This can make downstream behavior/order-dependent checks non-deterministic across runs/Python versions.
- Suggest preserving stable order (e.g., seed from
abstract_dimsorder and append discovered dims deterministically).
- Split end computation relies on dict insertion order
- In split metadata reconstruction, end bounds are inferred from
list(axis_splits.values()). - If split map construction order changes upstream, computed ranges can silently change.
- Suggest sorting by split start explicitly before deriving
(start,end)pairs.
Generated by Father the Guils' AI assistant, close comment if not relevant and blame me!
Haha you're a gangsta ! Did you copy-paste the diff in chatgpt/whatever, or use built-in Github tools? Thanks for the review anywy, I fix the issues and come back to you! |
No, I used the "developper way":
Basically, experience is that the LLM now is just the brain, but configurations of tools/agents querying it really matters. And the base OpenClaw framework permits to define easily as you want or need theses additional tools that really automate things! I did not use though prebuilt and closed source ChatGPT solutions for Github PRs, we redid it ourselves with OpenClaw+ChatGPT. Though, I intended anyway to test also the prebuilt ChatGPT/github review solution, I will keep you infromed of the most effective way, but I can bet... |
guillon
left a comment
There was a problem hiding this comment.
Fine for me once reported fixes are solved:
- mixed commits with main branch apparently
- Father's comments
13add95 to
6bc8466
Compare
Ok done |
|
Seems you have formatting issues: |
…he data structure
|
I let you merge when ready |
Motivation
We know how to build a scheduler from descript, but we also want to build descript from a scheduler.
Description
buffer_atpack_at