Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ein neuer Datensatz in einer Tabelle mit
google_geocode-Feld lässt sich im Debug-Modus nicht speichern:rex_yform_value_google_geocode::enterObject()ruftexplode(',', $this->getValue())auf. Ohne Wert (neuer Datensatz) ist dernull— seit PHP 8.1 deprecated. Im Debug-Modus macht der Error-Handler daraus eine Exception, die Transaktion bricht ab. Ohne Debug-Modus läuft der Save durch, die Meldung landet nur im Log.Aufgefallen beim Anlegen eines YCom-Users, dessen Tabelle ein Geocode-Feld hat.
Änderung
defaultwerden vorexplode()als String behandelt. Verhalten sonst unverändert: ohne Wert und Default wird wie bisher0,0gespeichert.testGoogleGeocodeSavesNewDatasetWithoutValuein derFieldTypesSuite.Test
php redaxo/bin/console yform:test:field-types: ohne Fix schlägt der neue Test mit genau dieser Meldung fehl, mit Fix 15/15 grün.🤖 Generated with Claude Code