Ripples server integration with namespace changes#429
Merged
yatisht merged 30 commits intoApr 29, 2026
Conversation
… and link against TBB::tbbmalloc in previous commit for usher-server binaries using scalable allocator C interface
…ed_nodes from muat data structure
…ncestors only within radius of given node
…omb and ripples-num-desc-search
…idate recombinants
Contributor
|
Great work, it's looking good here. While I develop the front end for this, I will probably have some additional requests (or might just submit some follow-up minor PRs myself) but this is enough for me to start developing with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR separates the namespaces for matOptimize::Mutation_Annotated_Tree and Mutation_Annotated_Tree. This allows us to integrate the usher-server codebase (which uses the matOptimize version) with Ripples.
Key Changes:
Note:
Currently, the Ripples code runs after place_sample_sequential and final_output every time a new sample is added. We might need to find a better place for its integration.