socket.cpp: set missing options#435
Merged
Merged
Conversation
main.cpp defaults options.keep_n_tree to 1 and sets only_one_tree if keep_n_tree is 1, but socket.cpp was missing that so clades.txt was not generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineage hunters noticed (#434, cov-lineages/pango-designation#3222) that annotations from clades.txt were missing from usher.bio results. It turned out that usher-sampled-server was not generating clades.txt because options.out_options.only_one_tree is required, but it was not set.
usher-sampled/driver/main.cpp has a default of 1 for options.keep_n_tree, and sets options.out_options.only_one_tree if keep_n_tree is 1. However, usher-sampled/driver/socket.cpp did not set those options.
This change adds two lines to socket.cpp to set keep_n_tree to 1 and only_one_tree to true, to match the default behavior of main.cpp. clades.txt is now generated by the modified usher-sampled-server.