feat: add support for iShares in Switzerland and update region handling#37
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds iShares Switzerland (ch) support and extends normalization for Swiss-specific exchange and number formats within the ETF provider implementation.
Changes:
- Adds Swiss iShares region configuration and updates supported-region documentation.
- Adds
ExchangeSIXplus iShares exchange aliases for SIX and additional NYSE variants. - Extends Swiss number normalization to strip curly apostrophe thousands separators and expands related tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents ch as a supported iShares region. |
| enums.go | Adds the SIX Swiss Exchange enum value. |
| internal/providers/ishares/client.go | Updates package documentation with the full supported iShares region list. |
| internal/providers/ishares/client_test.go | Expands supported-region construction tests to include UK, FR, and CH casing. |
| internal/providers/ishares/config.go | Adds the Swiss iShares region configuration. |
| internal/providers/ishares/normalize.go | Adds normalization aliases for NYSE variants and SIX. |
| internal/providers/ishares/column_resolver.go | Strips additional curly apostrophe thousands separators. |
| internal/providers/ishares/column_resolver_test.go | Adds coverage for one curly apostrophe Swiss number format. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the Swiss region (
ch) to the iShares provider, improves normalization of Swiss number formats, and extends exchange normalization and documentation. The main changes are grouped below.Swiss region (
ch) support for iSharesch) inishares, including URLs, currency, exchange, and mappings for asset classes, sectors, and locations.ch(Switzerland) in bothREADME.mdand code comments. [1] [2]chand other supported regions inclient_test.go.Exchange normalization
SIX) in exchange enums and normalization logic, including recognition of "SIX" and "SIX SWISS EXCHANGE". [1] [2]Number format normalization