feat(sslkeylogfile): added sslkeylogfile support - #43
Open
sm1thv1rus wants to merge 4 commits into
Open
sm1thv1rus wants to merge 4 commits into
sm1thv1rus wants to merge 4 commits into
Conversation
…or BoringSSL (all other TLS)
sm1thv1rus
force-pushed
the
feature/add-sslkeylogfile-support
branch
from
September 18, 2026 02:45
16fe0ee to
d986382
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
I added centralized
SSLKEYLOGFILEsupport viakeylog.rs, implemented in bothrustls::ClientConfigfor the QUIC connections and inboring2::ssl::SslContextBuilderfor everything else. This enables one to log SSL / TLS secrets in the whole library by the standardizedSSLKEYLOGFILEenvironment variable.Type
Related issues
Implements #42
How tested
cargo fmt --all -- --checkcargo clippy --workspace -- -D warnings- this failed, but only because of aneedless_late_initerror that appearedcargo clippy --workspace -- -D warnings -A clippy::needless_late_init- This succeeded instead of the abovecargo test --workspace -- --test-threads=1(V8 single-thread) - Importantly I added some tests to the mix so those got run herecargo doc --no-deps --workspace(no rustdoc warnings)cargo build --release --example getting_started && SSLKEYLOGFILE=./testing_sslkeylogfile.txt target/release/examples/getting_started- Importantly this one showed the creation of a validSSLKEYLOGFILEBreaking changes
As far as I can tell there's no breaking changes! All this does is add functionality by updating calling 2 functions, one for each of the SSL libraries.
Scope
Checklist
// SAFETY:comment