[samdark]

Q	A
Is bugfix?	Yes
New feature?	No
Breaks BC?	No
Fixed issues	Extracted from #110

FileCache::set() can report success after a failed permission or expiry update. A write warning can also escape through an application error handler.

Return false when permission or expiry updates fail, and suppress write warnings. The existing cache file format and direct-write behavior remain in place.

This is the first PR in the bugfix stack extracted from #110.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3d7039ae-92f6-4a5c-8f79-d18693a75a26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟡 Changes recommended

The existing concurrency test rejects write failures that the new behavior intentionally reports.

1 open issue

• Concurrency test rejects valid write failures · New

What changed in this PR

This focused bugfix makes FileCache::set() report write failures reliably while preserving the existing cache format and direct-write behavior.

Changes:

• Require complete writes and suppress write warnings.
• Return false when permission or expiry updates fail.
• Add regression tests and a changelog entry.

File	Description
tests/​WriteFailureTest.php	Tests short writes, warnings, and metadata failures.
src/​FileCache.php	Tightens write and metadata success checks.
CHANGELOG.md	Documents the failure-reporting fix.

_{Review effort: Balanced}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.68%. Comparing base (0b76110) to head (7cc2068).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     91.56%   92.68%   +1.11%     
  Complexity       69       69              
============================================
  Files             1        1              
  Lines           166      164       -2     
============================================
  Hits            152      152              
+ Misses           14       12       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.