Conversation
Update against the fork
I wrote (but didn't completely test 100%) a patch to allow offline signing on an airgapped computer to prevent users from needing to expose their private keys to an online computer in order to access a fork. This patch also is important because it allows including claimer.py as a module (which is not currently possible because there is no `if __name__=='__main__':` check)
|
It's a great feature, but the diff is hard to read due to the additional refactoring. A lot of people rely on this code for correctness and it needs to audited. I personally would prefer if there were separate commits and/or PRs to split the refactoring from the new functionality. |
Author
|
You can't really add the feature without refactoring it into subparts to
make some parts optional. As far as I know that's the only change I made
in this diff.
…On Wed, Jul 4, 2018, 11:50 AM Forkdrop.io ***@***.***> wrote:
It's a great feature, but the diff is hard to read due to the additional
refactoring. A lot of people rely on this code for correctness and it needs
to audited. I personally would prefer if there were separate commits and/or
PRs to split the refactoring from the new functionality.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA1kMGQFF_BbtYCVjSpxQRXj94bLn3iEks5uDOQ8gaJpZM4U2gWv>
.
|
Author
|
Okay, I can fix it with multiple commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote (but didn't completely test 100%) a patch to allow offline signing on an airgapped computer to prevent users from needing to expose their private keys to an online computer in order to access a fork. This patch also is important because it allows including claimer.py as a module (which is not currently possible because there is no
if __name__=='__main__':check)