test(vibe): make bash-wrap quote assertion platform-aware - #1120
Closed
lwandrebeck wants to merge 1 commit into
Closed
test(vibe): make bash-wrap quote assertion platform-aware#1120lwandrebeck wants to merge 1 commit into
lwandrebeck wants to merge 1 commit into
Conversation
wrap_single_command quotes with double quotes on Windows (cmd) and single quotes on POSIX shells, but bash_wraps_general_command_and_preserves_timeout hardcoded the single-quoted form, so the test failed only on windows-latest (left: "lean-ctx -c \"git status\"", right: "lean-ctx -c 'git status'"). Mirror the existing platform-aware expect_wrapped helper: pick the expected wrapping via cfg!(windows). Unix expectation is byte-identical to before. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
|
Cherry-picked to main as 58b2895. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrap_single_command quotes with double quotes on Windows (cmd) and single quotes on POSIX shells, but bash_wraps_general_command_and_preserves_timeout hardcoded the single-quoted form, so the test failed only on windows-latest (left: "lean-ctx -c "git status"", right: "lean-ctx -c 'git status'").
Mirror the existing platform-aware expect_wrapped helper: pick the expected wrapping via cfg!(windows). Unix expectation is byte-identical to before.
Summary
What does this PR change and why
Test plan
cd rust && cargo test -- --test-threads=1(the suite shares process-global state; CI serializes it too)cd rust && cargo clippy --all-targets --all-features -- -D warningscd rust && cargo fmt --checknpm test/ build stepsNotes for reviewers
Contributor License Agreement
First-time contributors: a bot will ask you to sign our one-time
CLA (it keeps lean-ctx
Apache-2.0 and free for individual developers — see §8). You sign once by
replying to this PR with:
I have read the CLA Document and I hereby sign the CLA