Code refactoring around postgres versions. #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use PG version represented as an integer internally insteead of the float (float comparisons are imprecise). Instead of passing one version of the disk stat collector pass one version per each cluster (since wal directories are per cluster). Minor refactoring.
Contributor
Author
|
👍 |
Vampouille
suggested changes
Jul 3, 2017
|
|
||
| from pg_view.loggers import logger | ||
| from pg_view.models.parsers import ProcNetParser | ||
| from pg_view.utils import STAT_FIELD, dbversion_as_float |
There was a problem hiding this comment.
dbversion_as_float function is still use here :
https://github.com/zalando/pg_view/pull/89/files#diff-8d664710cdcbb1b16504f2b8032196efR114
I have following error while testing your PR :
Traceback (most recent call last):
File "pg_view.py", line 6, in <module>
main()
File "/home/xxx/pg_view/pg_view/__init__.py", line 208, in main
if not establish_user_defined_connection(instance, conn, clusters):
File "/home/xxx/pg_view/pg_view/models/db_client.py", line 114, in establish_user_defined_connection
dbver = dbversion_as_float(pgcon)
NameError: name 'dbversion_as_float' is not defined
Missed in the previos commit.
Contributor
Author
|
👍 |
|
Any updates? |
Vampouille
approved these changes
Jun 27, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use PG version represented as an integer internally insteead of
the float (float comparisons are imprecise). Instead of passing
one version of the disk stat collector pass one version per each
cluster (since wal directories are per cluster). Minor refactoring.
Fixes #88