2.17 Headline changes and Alert details #623
Conversation
psiinon
force-pushed
the
2.17/headline
branch
from
0d03669 to
b1f5f34
Compare
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to reach out to us for assistance. Just send a PR comment with Examples: |
| <a href="https://www.zaproxy.org/docs/alerts/">https://www.zaproxy.org/docs/alerts/</a> | ||
| </p> | ||
|
|
||
| <a name="alertfields"></a><H2>Alert Fields</H2> |
There was a problem hiding this comment.
Shall we link these via id instead of separate anchors?
There was a problem hiding this comment.
Sory, I'm not sure what you mean..
There was a problem hiding this comment.
Like we've done for scan rules in the help/site:
<H2 id="alertfields">Alert Fields</H2>
There was a problem hiding this comment.
This seems to be what we've done in other core help pages, and it results in links to the headings as per https://www.zaproxy.org/docs/desktop/start/features/alerts/#alert-overrides
There was a problem hiding this comment.
https://www.zaproxy.org/docs/desktop/addons/active-scan-rules/#id-40032
I guess we've mixed, so it doesn't matter.
addOns/help/src/main/javahelp/contents/start/features/alerts.html
Outdated
Show resolved
Hide resolved
addOns/help/src/main/javahelp/contents/start/features/alerts.html
Outdated
Show resolved
Hide resolved
addOns/help/src/main/javahelp/contents/start/features/alerts.html
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
2.17/headline
branch
from
b1f5f34 to
06331ba
Compare
|
Thank you! |
psiinon
force-pushed
the
2.17/headline
branch
from
06331ba to
3153375
Compare
|
Added the lib updates, enhancements and bugfixes. |
|
@kingthorin this ok now? |
kingthorin
left a comment
kingthorin
left a comment
There was a problem hiding this comment.
Yes. Though there's a flatlaf PR inflight this morning. So tweak that entry?
Signed-off-by: Simon Bennetts <[email protected]>
psiinon
force-pushed
the
2.17/headline
branch
from
3153375 to
4ff3604
Compare
|
Done, but I am expecting more changes to this file 😁 |
|
Not ones that are worth holding this PR for though... |
3 participants
No description provided.