Repository navigation
Fix dependencies for blosc extension - #860
Merged
Merged
Conversation
The blosc extension only depends on `blosc.h`, not any of the other libraries' headers. And if we're using internal blosc, then the other libraries are handled by `blosc_lib`.
Also, don't build vendored Zlib internally if not using vendored blosc, as it isn't necessary.
Contributor
|
thanks, this looks good. I requested review from @mkitti who knows this stuff better than me. if that takes too long I will ask an llm. |
Contributor
|
This also looks good to me. I think this is scoped to meson though. Is that the only build method we support? I would just add a note that this only affects thr meson build path. |
mkitti
approved these changes
Sep 18, 2026
mkitti
left a comment
mkitti
left a comment
Contributor
There was a problem hiding this comment.
Nevermind. The build system was switched to meson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blosc extension only depends on
blosc.h, not any of the other libraries' headers. And if we're using internal blosc, then the other libraries are handled byblosc_lib.Additionally, Zlib is only required if building blosc internally, but also add an option to allow using a system copy of it if desired.