refactor: extract legacy storage interfaces into zarr-storage - #4318
Draft
d-v-b wants to merge 2 commits into
Draft
refactor: extract legacy storage interfaces into zarr-storage#4318d-v-b wants to merge 2 commits into
d-v-b wants to merge 2 commits into
Conversation
Assisted-by: Codex:GPT-6
Assisted-by: Codex:GPT-6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4318 +/- ##
==========================================
+ Coverage 94.21% 94.23% +0.01%
==========================================
Files 92 92
Lines 12871 12880 +9
==========================================
+ Hits 12127 12137 +10
+ Misses 744 743 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an LLM-authored PR that copies our store APIs into a subpackage called
zarr-storage. This subpackage would be published and versioned separately fromzarr. All store APIs fromzarrare found inzarr-storagein alegacymodule.This PR contains no changes to
zarr. If this PR works, then we would makezarrdepend onzarr-storage, and re-export symbols as needed to ensure that no public API changes. A later step would be to develop a new, improved store API inzarr-storage, while preserving the legacy API indefinitely for existing users.see the original PR, with an AI-authored description, here: d-v-b#325
For reviewers
Happy to bikeshed the layout of
zarr_storage.legacy, or explain the motivation for copying these APIs! I started a Zulip thread#Zarr-Python > subpackaging store and codec APIs specifically about this direction, in case folks want a more conversational dialogue.See also
Author attestation
TODO
docs/user-guide/*.mdchanges/