Fix excessive realloc in DArray_pop#14
Open
abbioro wants to merge 2 commits intozedshaw:masterfrom
abbioro:darray_pop_fix
Open
Fix excessive realloc in DArray_pop#14abbioro wants to merge 2 commits intozedshaw:masterfrom abbioro:darray_pop_fix
abbioro wants to merge 2 commits intozedshaw:masterfrom
abbioro:darray_pop_fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reallocing on every pop except the one where it was supposed to realloc, basically every pop when the max was greater than the expand rate. I also changed the 1st condition when popping so that it correctly resizes to 301 now that it reallocs correctly.
I also added a couple checks to the tests so that after every push and pop it makes sure that max is a multiple of expand_rate + 1 (as long as we're just pushing/popping elements it should resize in increments of the expand_rate).