Fix Clang-23 RC build - #2482
Open
evantypanski wants to merge 4 commits into
Open
Conversation
This was included transitively but should not be.
evantypanski
force-pushed
the
topic/etyp/transitive-include-fix
branch
from
August 25, 2026 19:45
945b8b4 to
e68109d
Compare
evantypanski
marked this pull request as ready for review
September 3, 2026 19:38
Member
Author
|
Marked this as ready. Tested brew's LLVM-23 and it works with this branch without warnings. only iffy spot is the fiber bump. We could drop that since it was there before, it just cleans up some warnings (and I think @ckreibich complained about spicy warnings to me relatively recently ;) ) |
bbannier
reviewed
Sep 4, 2026
Thi `/` fix was only proper for MSVC. It broke when using an absolute path on Mac. I used `-isystem /Library/...` when testing Clang 23.1 RC.
Also suppresses warnings on a couple unused template functions that we would prefer be used.
We had a few pragmas, but this one couldn't actually be fixed by pragmas since the warning technically happened in a system include. Bleh. Then, this includes fiber as a 3rdparty include.
evantypanski
force-pushed
the
topic/etyp/transitive-include-fix
branch
from
September 8, 2026 14:21
e68109d to
ef61f80
Compare
bbannier
approved these changes
Sep 8, 2026
bbannier
left a comment
bbannier
left a comment
Member
There was a problem hiding this comment.
Looks good to me assuming CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft since I'm going to look at other stuff too (and so I make sure to come back to this), this isn't urgent.
Just tested Clang 23 RC3 and hit an error building Zeek:
Also changed this to fix some warnings, as well.
Note this fixes warnings in fiber/ - I did that as patches (see zeek/fiber#1). Unless they respond upstream to the other patch, I don't see much reason to not mildly maintain it ourselves.