Update Angular 16 - #1996
Open
lthuong wants to merge 29 commits into
Open
Conversation
Member
|
Okay! Ich habe es jetzt geschafft, das neue Frontend lokal zu starten. Insgesamt scheint alles zu funktionieren - gute Arbeit! Mit sind ein paar Sachen aufgefallen:
|
Member
|
Ich sehe außerdem beim Install-Prozess viele deprecation warnings. Das könnte evtl. ein Problem werden? |
Contributor
Author
Vielen Dank noch mal für die Mühe und Feedbacks 👍 |
Member
|
Font spacing / letter spacing an folgenden Stellen
|
| g = g[3]; | ||
| g = decodeURIComponent(g); | ||
| h && (g = atob(g)); | ||
| h && (g = Buffer.from(g, 'base64').toString()); |
Member
There was a problem hiding this comment.
omg... was ist das? An dieser Komponente haben wir seit Jahren nichts gemacht?
|
|
||
| ::ng-deep .mdc-list-item__primary-text { | ||
| font-size: 14px !important; | ||
| font-size: 13.4px !important; |
Member
There was a problem hiding this comment.
Also... die 14px fand ich schon gut - aber es ist das letter-spacing, das mich stört.
Wenn Du hier
letter-spacing: normal;
einfügst, müsste es passen; auch an den anderen Stellen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.