fix(zrpc): aggregate kube resolver addresses by EndpointSlice#5659
Open
artisth wants to merge 3 commits into
Open
fix(zrpc): aggregate kube resolver addresses by EndpointSlice#5659artisth wants to merge 3 commits into
artisth wants to merge 3 commits into
Conversation
3f0ace5 to
393a62f
Compare
393a62f to
48ca7f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed
This PR changes the zRPC Kubernetes resolver to keep endpoint addresses per EndpointSlice and aggregate all slices before updating gRPC resolver state.
Previously, every EndpointSlice update replaced the global endpoint address set with only the addresses from the updated slice. If one slice was updated to an empty endpoint list while other slices still had ready endpoints, the resolver could publish an empty address list and gRPC would report
produced zero addresses.The new implementation:
Why
Kubernetes services can have multiple EndpointSlice objects. A single EndpointSlice update should not discard addresses from other slices.
Tests
go test ./zrpc/resolver/internal/kube ./zrpc/resolver/internalgo test ./zrpc/...