-
Notifications
You must be signed in to change notification settings - Fork 5
Cypress: Setup Fixture Seeding - Content List #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: test/seed-data-content-actions
Are you sure you want to change the base?
Cypress: Setup Fixture Seeding - Content List #3915
Conversation
8ada555 to
e28b7eb
Compare
e28b7eb to
d74d0b5
Compare
17a6716 to
0851b8d
Compare
7f7a907 to
b184802
Compare
77cb1b8 to
dd1fd0c
Compare
28425c1 to
5e4fb0a
Compare
5e4fb0a to
78026f2
Compare
| cy.get(".MuiDataGrid-cell").contains(contentItems[1].data.text); | ||
| cy.getBySelector("MultiPageTableSearchField") | ||
| .type("{selectAll}{del}") | ||
| .wait(500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this "wait(500)" introduced? Is it required?
cypress/e2e/content/list.spec.js
Outdated
| }); | ||
|
|
||
| it("Sorts list items", () => { | ||
| it("Sorts list items", function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'function' keyword is not consistent across our test suites
| noRowsVariant: "skeleton", | ||
| }, | ||
| row: { | ||
| className: "listItemTableRow", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for introducing a new className for the rows?
NOTE: This work is based on and requires #3899 to be merged first.