Skip to content

Conversation

@geodem127
Copy link
Contributor

@geodem127 geodem127 commented Nov 26, 2025

  • created content list fixture
  • enabled all skipped tests
  • updated element selectors

NOTE: This work is based on and requires #3899 to be merged first.

@geodem127 geodem127 changed the base branch from dev to test/seed-data-content-actions November 26, 2025 08:05
@geodem127 geodem127 force-pushed the test/seed-data-content-actions branch 3 times, most recently from 8ada555 to e28b7eb Compare November 27, 2025 18:56
@geodem127 geodem127 self-assigned this Dec 1, 2025
@geodem127 geodem127 force-pushed the test/seed-data-content-actions branch from e28b7eb to d74d0b5 Compare December 1, 2025 14:21
@geodem127 geodem127 force-pushed the test/seed-data-content-list branch 2 times, most recently from 17a6716 to 0851b8d Compare December 1, 2025 14:39
@geodem127 geodem127 force-pushed the test/seed-data-content-actions branch 2 times, most recently from 7f7a907 to b184802 Compare December 1, 2025 14:49
@geodem127 geodem127 force-pushed the test/seed-data-content-list branch 2 times, most recently from 77cb1b8 to dd1fd0c Compare December 1, 2025 14:54
@geodem127 geodem127 requested a review from finnar-bin December 16, 2025 23:14
@geodem127 geodem127 force-pushed the test/seed-data-content-list branch from 28425c1 to 5e4fb0a Compare December 17, 2025 15:53
@geodem127 geodem127 force-pushed the test/seed-data-content-list branch from 5e4fb0a to 78026f2 Compare December 17, 2025 15:58
cy.get(".MuiDataGrid-cell").contains(contentItems[1].data.text);
cy.getBySelector("MultiPageTableSearchField")
.type("{selectAll}{del}")
.wait(500);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this "wait(500)" introduced? Is it required?

});

it("Sorts list items", () => {
it("Sorts list items", function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'function' keyword is not consistent across our test suites

noRowsVariant: "skeleton",
},
row: {
className: "listItemTableRow",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for introducing a new className for the rows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants