Repository navigation
Support for zig 0.16.0-dev - #35
Conversation
For now only 0.15.2 and master (0.16.0-dev nightly)
|
Hi, thanks for the MR! I'm good with merging this in but could you explain why it needs to link in libc now? Is that something that changed with Zig 0.16? I'm not keeping up to date with Zig updates so if someone else wants to have a look at the MR please do so :) |
|
Hi Srekel, it did link libc before like this: So I changed it to the recommended alternative |
|
Oh, now I see. Sounds good. Happy to merge but I am not able to test it, so will leave it open for a while and see if anyone has any comments. |
|
@soeren-spindler I opened soeren-spindler#1 on your fork to add support for some recent changes. also: maybe it makes sense to change this PR from |
|
Oh sorry, yeah I think that's why I didn't merge it yet. I'm OK with merging it, but let me know if you want to get your changes in first @ezzieyguywuf . |
|
@Srekel I'll submit a followup PR for my changes if you go ahead and merge this |
|
will the minimum zig version be updated to 0.16? |
It's currently at 0.15.1 because it supports that version. That doesn't prevent you from using it with 0.16. Why would you want that version to be increased? |
Hello guys,
I made some changes in order to support zig 0.16.0-dev in my demo project and wanted to contribute that back to you.
I guess most changes are straight forward. Replaced removed function calls with their newer alternative.
The point I'm not sure about is the
flecs_abortfunction.I assumed a version check is adequate because it's a callback, not in any hot path.
Regarding
allow_unsafe_unwindandcontext:I left them as default values since I couldn't find a reason not to do so.
But honestly, especially for
allow_unsafe_unwindI don't know what implicationstruewould exactly have.In order to check backwards compatibility I added zig version 0.15.1 and master to matrix strategy in the github action.
I'm new to the zig community and this is my first PR in any open source project. Please forgive me in case I missed something.
Greetings ☕ Sören