refactor: update tests to add big endian miri check#735
refactor: update tests to add big endian miri check#735Its-Just-Nans merged 5 commits intomasterfrom
Conversation
Its-Just-Nans
commented
Mar 20, 2026
- refactor tests to be self contained
- add a miri big endian test
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the existing test suite to improve self-containment and introduces support for Miri testing on big-endian architectures. The changes involve moving module-level Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
The changes in this PR appropriately add #[cfg(target_endian = "little")] guards to tests that use filesystem operations, making them compatible with Miri CI. The new endianness CI job and import reorganization are clean and correct. No blocking issues found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request refactors the tests to be self-contained by moving imports into individual test functions. It also adds conditional compilation attributes to skip certain tests on big-endian systems, specifically for Miri CI runs, due to filesystem dependencies or long execution times. The changes are logical and well-executed towards the stated goal. I've only found some minor grammatical issues in the comments explaining why tests are disabled, which I've commented on. Once those are addressed, this PR should be good to merge.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: n4n5 <git@n4n5.dev>