Skip to content

refactor: update tests to add big endian miri check#735

Merged
Its-Just-Nans merged 5 commits intomasterfrom
add-endian-tests
Mar 20, 2026
Merged

refactor: update tests to add big endian miri check#735
Its-Just-Nans merged 5 commits intomasterfrom
add-endian-tests

Conversation

@Its-Just-Nans
Copy link
Member

  • refactor tests to be self contained
  • add a miri big endian test

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the existing test suite to improve self-containment and introduces support for Miri testing on big-endian architectures. The changes involve moving module-level use statements into individual test functions and conditionally compiling several file system-dependent tests to run only on little-endian systems, thereby facilitating Miri execution on big-endian environments.

Highlights

  • Test Refactoring: Refactored existing tests to be more self-contained by moving use statements directly into individual test functions, reducing global dependencies within the test modules.
  • Miri Big-Endian Test Support: Introduced conditional compilation (#[cfg(target_endian = "little")]) for several tests, primarily to enable Miri testing on big-endian systems by excluding file system-related tests that are too long or problematic for Miri CI.
  • Conditional Test Execution: Applied #[cfg(target_endian = "little")] to numerous tests across multiple files, ensuring that tests involving file system operations or large data are only executed on little-endian architectures, thus improving Miri compatibility.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@amazon-q-developer amazon-q-developer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR appropriately add #[cfg(target_endian = "little")] guards to tests that use filesystem operations, making them compatible with Miri CI. The new endianness CI job and import reorganization are clean and correct. No blocking issues found.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the tests to be self-contained by moving imports into individual test functions. It also adds conditional compilation attributes to skip certain tests on big-endian systems, specifically for Miri CI runs, due to filesystem dependencies or long execution times. The changes are logical and well-executed towards the stated goal. I've only found some minor grammatical issues in the comments explaining why tests are disabled, which I've commented on. Once those are addressed, this PR should be good to merge.

Its-Just-Nans and others added 3 commits March 19, 2026 22:24
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: n4n5 <git@n4n5.dev>
@Its-Just-Nans Its-Just-Nans changed the title refactor: refactor test to add big endian miri tests refactor: update tests to add big endian miri check Mar 20, 2026
@Its-Just-Nans Its-Just-Nans added this pull request to the merge queue Mar 20, 2026
@Its-Just-Nans Its-Just-Nans added this to the 8.4.0 milestone Mar 20, 2026
@Its-Just-Nans Its-Just-Nans self-assigned this Mar 20, 2026
Merged via the queue into master with commit 350b8a2 Mar 20, 2026
131 checks passed
@Its-Just-Nans Its-Just-Nans deleted the add-endian-tests branch March 20, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant